Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSAL and OIDC support #2308

Closed
wants to merge 26 commits into from
Closed

MSAL and OIDC support #2308

wants to merge 26 commits into from

Commits on Mar 17, 2023

  1. Upgrade auth stack to latest versions 

    Spike: upgrade hashicorp/go-azure-helpers to 0.40

Unblock Azure auth by using long-lived context

Fix logic bug in getting object id.

Upgrade some more minor dependencies

minor dependency upgrades

Switch back to ADAL but keep the upgrades.

Fix nil pointer bug in getClientConfig
    @thomas11
    thomas11 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    eb30a41 View commit details
    Browse the repository at this point in the history

  2. Factor details of auth better, extra nil check for safety

    @thomas11
    thomas11 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    083a045 View commit details
    Browse the repository at this point in the history

  3. [WIP] Cherry-pick MSAL changes from tkappler/upgrade-azure-helpers.

    @thomas11
    thomas11 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    ab4f7b1 View commit details
    Browse the repository at this point in the history

  4. Move auth code into its own file

    @thomas11
    thomas11 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    b502903 View commit details
    Browse the repository at this point in the history

  5. Use correct audience for MSAL Key Vault token #1566

    @thomas11
    thomas11 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    1f0e274 View commit details
    Browse the repository at this point in the history

  6. Dependency upgrades

    @thomas11
    thomas11 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    2d27137 View commit details
    Browse the repository at this point in the history

  7. Add OIDC config to auth builder creation

    @thomas11
    thomas11 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    dc6b427 View commit details
    Browse the repository at this point in the history

  8. Temporarily use oidc-test client id and comment client secret to test… 

    … OIDC
    @thomas11
    thomas11 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    23fc749 View commit details
    Browse the repository at this point in the history

  9. need to set ARM_USE_OIDC

    @thomas11
    thomas11 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    b963e62 View commit details
    Browse the repository at this point in the history

  10. Need UseMicrosoftGraph and write permissions for JWT token

    @thomas11
    thomas11 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    b5acb2f View commit details
    Browse the repository at this point in the history

  11. Temporarily add back some Q logging

    @thomas11
    thomas11 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    4a37ee7 View commit details
    Browse the repository at this point in the history

  12. Split off OIDC test

    @thomas11
    thomas11 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    cd7e4a0 View commit details
    Browse the repository at this point in the history

  13. try to cat q.Q output

    @thomas11
    thomas11 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    284bfbb View commit details
    Browse the repository at this point in the history

  14. Rework build tags

    @thomas11
    thomas11 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    e970e89 View commit details
    Browse the repository at this point in the history

  15. Name short test runs accordingly

    @thomas11
    thomas11 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    d1112fb View commit details
    Browse the repository at this point in the history

  16. Try echo-ing q.Q again

    @thomas11
    thomas11 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    104c50f View commit details
    Browse the repository at this point in the history

  17. Fix oidc-only test build

    @thomas11
    thomas11 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    60b1b16 View commit details
    Browse the repository at this point in the history

  18. Test via az cli as well, get q.Q logs after failures

    @thomas11
    thomas11 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    4d2e5c9 View commit details
    Browse the repository at this point in the history

  19. Allow the CLI test to fail for now so we get more overall results.

    @thomas11
    thomas11 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    0396389 View commit details
    Browse the repository at this point in the history

  20. regenerate stuff after rebasing

    @thomas11
    thomas11 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    aad5bba View commit details
    Browse the repository at this point in the history

  21. Don't need the cli for OICD

    @thomas11
    thomas11 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    f3c2c95 View commit details
    Browse the repository at this point in the history

  22. Sync azure-rest-api-specs with master after rebase 

    Regenerate versions
    @thomas11
    thomas11 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    12fdd2e View commit details
    Browse the repository at this point in the history

  23. Fall back to ADAL when the CLI is used for auth

    @thomas11
    thomas11 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    76a0f0c View commit details
    Browse the repository at this point in the history

  24. Different test for az cli, remove q.Q

    @thomas11
    thomas11 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    cca3737 View commit details
    Browse the repository at this point in the history

  25. Remove q.Q support from GH action, run nodejs only OIDC tests

    @thomas11
    thomas11 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    adff53f View commit details
    Browse the repository at this point in the history

  26. Comment the OIDC via cli test that's not fully supported

    @thomas11
    thomas11 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    d29f8f2 View commit details
    Browse the repository at this point in the history