Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSAL and OIDC support #2320

Merged
merged 20 commits into from
Mar 28, 2023
Merged

MSAL and OIDC support #2320

merged 20 commits into from
Mar 28, 2023

Commits on Mar 22, 2023

  1. Upgrade auth stack to latest versions. 

    Unblock Azure auth by using long-lived context.
    @thomas11
    thomas11 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    2274458 View commit details
    Browse the repository at this point in the history

  2. Factor details of auth better, extra nil check for safety

    @thomas11
    thomas11 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    24d6b38 View commit details
    Browse the repository at this point in the history

  3. Switch from ADAL to MSAL authentication

    @thomas11
    thomas11 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    ba949bc View commit details
    Browse the repository at this point in the history

  4. Move auth code into its own file

    @thomas11
    thomas11 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    46a1e4b View commit details
    Browse the repository at this point in the history

  5. Use correct audience for MSAL Key Vault token #1566

    @thomas11
    thomas11 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    c256cfc View commit details
    Browse the repository at this point in the history

  6. Add OIDC config to auth builder creation

    @thomas11
    thomas11 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    d59384e View commit details
    Browse the repository at this point in the history

  7. Temporarily use oidc-test client id and comment client secret to test… 

    … OIDC
    @thomas11
    thomas11 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    d8e21e2 View commit details
    Browse the repository at this point in the history

  8. Need UseMicrosoftGraph and write permissions for JWT token

    @thomas11
    thomas11 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    03eb5c8 View commit details
    Browse the repository at this point in the history

  9. Rework build tags, CI work

    @thomas11
    thomas11 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    6bd99d2 View commit details
    Browse the repository at this point in the history

  10. Name short test runs accordingly

    @thomas11
    thomas11 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    c6892b3 View commit details
    Browse the repository at this point in the history

  11. Fix oidc-only test build

    @thomas11
    thomas11 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    327914a View commit details
    Browse the repository at this point in the history

  12. Don't need the cli for OICD

    @thomas11
    thomas11 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    b1c72c3 View commit details
    Browse the repository at this point in the history

  13. Fall back to ADAL when the CLI is used for auth

    @thomas11
    thomas11 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    fff69df View commit details
    Browse the repository at this point in the history

  14. Different test for az cli, remove q.Q 

    Clarify oidc-test comment
    @thomas11
    thomas11 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    771f231 View commit details
    Browse the repository at this point in the history

  15. Run nodejs-only OIDC tests

    @thomas11
    thomas11 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    de9cd54 View commit details
    Browse the repository at this point in the history

  16. Sync with latest api specs from master

    @thomas11
    thomas11 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    af9d8f7 View commit details
    Browse the repository at this point in the history

  17. Reset schema to the one in master, no schema changes expected here

    @thomas11
    thomas11 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    3c24756 View commit details
    Browse the repository at this point in the history

  18. Move id-token permission to where it's needed 

    This not only limits the security blast radius, but also unblocks
schema-tools from adding PR comments. Previously, it had the write
permission by default, but adding the id-token permission setting
globally reset all others: "If you specify the access for any of these
scopes, all of those that are not specified are set to none."
    @thomas11
    thomas11 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    a21dec5 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. Simplify OIDC test runs in CI

    @thomas11
    thomas11 committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    58066d1 View commit details
    Browse the repository at this point in the history

  2. Review follow-up: use OIDC_ARM_CLIENT_ID

    @thomas11
    thomas11 committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    f1a44f8 View commit details
    Browse the repository at this point in the history