-
Notifications
You must be signed in to change notification settings - Fork 51
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Migrate from @azure/ms-rest-nodeauth to @azure/identity as the former…
… is deprecated and has a CVE (#2225) Resolves #1440 The NodeJS SDK has some hand-written mixins that haven't been updated in a long time. This PR replaces the deprecated @azure/ms-rest-nodeauth package, that has a CVE open (see #1440), with the current @azure/identity package. The previous PR #2217 restored some test coverage for this change, although not all auth methods are covered. CI uses Service Principal with client secret, and I ran it locally using CLI auth.
- Loading branch information
Showing
4 changed files
with
19 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.