Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert examples with pulumi convert #1377

Merged
merged 10 commits into from
Feb 27, 2024
Merged

Convert examples with pulumi convert #1377

merged 10 commits into from
Feb 27, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Oct 11, 2023

Stats

Baseline 1441 API locations with examples

Provider: azurerm
Success rate: 96.39% (8779/9108)

Converted 96.11% of csharp examples (1459/1518)
Converted 96.11% of go examples (1459/1518)
Converted 98.16% of java examples (1490/1518)
Converted 96.11% of python examples (1459/1518)
Converted 96.11% of typescript examples (1459/1518)
Converted 95.72% of yaml examples (1453/1518)

Experimental 1441 API locations with examples

Provider: azurerm
Success rate: 98.30% (8999/9155)

Converted 98.04% of csharp examples (1500/1530)
Converted 98.04% of go examples (1500/1530)
Converted 98.30% of java examples (1504/1530)
Converted 98.04% of python examples (1500/1530)
Converted 98.04% of typescript examples (1500/1530)
Converted 99.34% of yaml examples (1495/1505)

Newly Failing

Example started failing: #/resources/azure:automation/runBook:RunBook#1
typescript 0
csharp 0
go 0
java 2 not yet implemented: call notImplemented; Terraform input not yet implemented: path
python 0
Example started failing: #/types/azure:redis/CacheRedisConfiguration:CacheRedisConfiguration/aofStorageConnectionString1
java 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
python 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
typescript 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
yaml 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
csharp 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
go 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
Example started failing: #/types/azure:redis/CacheRedisConfiguration:CacheRedisConfiguration/aofStorageConnectionString1
csharp 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
go 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
java 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
python 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
typescript 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
yaml 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
Example started failing: #/types/azure:redis/CacheRedisConfiguration:CacheRedisConfiguration/aofStorageConnectionString1
java 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
python 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
typescript 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
yaml 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
csharp 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
go 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
Example started failing: #/types/azure:redis/CacheRedisConfiguration:CacheRedisConfiguration/aofStorageConnectionString1
go 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
java 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
python 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
typescript 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
yaml 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
csharp 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
Example started failing: #/types/azure:redis/CacheRedisConfiguration:CacheRedisConfiguration/aofStorageConnectionString1
csharp 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
go 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
java 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
python 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
typescript 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
yaml 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
Example started failing: #/types/azure:redis/CacheRedisConfiguration:CacheRedisConfiguration/aofStorageConnectionString1
python 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
typescript 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
yaml 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
csharp 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
go 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
java 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
Example started failing: #/types/azure:redis/CacheRedisConfiguration:CacheRedisConfiguration/notifyKeyspaceEvents
csharp 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
go 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
java 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
python 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
typescript 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
yaml 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
Example started failing: #/types/azure:redis/CacheRedisConfiguration:CacheRedisConfiguration/notifyKeyspaceEvents
csharp 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
go 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
java 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
python 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
typescript 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
yaml 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
Example started failing: #/types/azure:redis/CacheRedisConfiguration:CacheRedisConfiguration/notifyKeyspaceEvents
typescript 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
yaml 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
csharp 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
go 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
java 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
python 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
Example started failing: #/types/azure:redis/CacheRedisConfiguration:CacheRedisConfiguration/notifyKeyspaceEvents
python 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
typescript 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
yaml 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
csharp 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
go 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
java 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
Example started failing: #/types/azure:redis/CacheRedisConfiguration:CacheRedisConfiguration/notifyKeyspaceEvents
typescript 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
yaml 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
csharp 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
go 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
java 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
python 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
Example started failing: #/types/azure:redis/CacheRedisConfiguration:CacheRedisConfiguration/notifyKeyspaceEvents
python 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
typescript 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
yaml 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
csharp 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
go 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
java 2 Unsupported block type: Blocks of type "redis_configuration" are not expected here.
Example started failing: #/resources/azure:mssql/serverExtendedAuditingPolicy:ServerExtendedAuditingPolicy#2
go 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
java 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
python 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
typescript 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
yaml 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
csharp 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
Example started failing: #/resources/azure:mssql/serverExtendedAuditingPolicy:ServerExtendedAuditingPolicy#2
java 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
python 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
typescript 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
yaml 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
csharp 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
go 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
Example started failing: #/resources/azure:mssql/serverExtendedAuditingPolicy:ServerExtendedAuditingPolicy#2
csharp 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
go 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
java 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
python 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
typescript 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
yaml 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
Example started failing: #/resources/azure:mssql/serverExtendedAuditingPolicy:ServerExtendedAuditingPolicy#2
java 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
python 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
typescript 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
yaml 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
csharp 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
go 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
Example started failing: #/resources/azure:mssql/serverExtendedAuditingPolicy:ServerExtendedAuditingPolicy#2
go 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
java 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
python 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
typescript 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
yaml 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
csharp 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
Example started failing: #/resources/azure:mssql/serverExtendedAuditingPolicy:ServerExtendedAuditingPolicy#2
csharp 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
go 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
java 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
python 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
typescript 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
yaml 2 Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.
Example started failing: #/resources/azure:datafactory/linkedServiceAzureBlobStorage:LinkedServiceAzureBlobStorage#1
java 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
python 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
typescript 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
yaml 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
csharp 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
go 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
Example started failing: #/resources/azure:datafactory/linkedServiceAzureBlobStorage:LinkedServiceAzureBlobStorage#1
csharp 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
go 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
java 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
python 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
typescript 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
yaml 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
Example started failing: #/resources/azure:datafactory/linkedServiceAzureBlobStorage:LinkedServiceAzureBlobStorage#1
java 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
python 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
typescript 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
yaml 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
csharp 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
go 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
Example started failing: #/resources/azure:datafactory/linkedServiceAzureBlobStorage:LinkedServiceAzureBlobStorage#1
java 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
python 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
typescript 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
yaml 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
csharp 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
go 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
Example started failing: #/resources/azure:datafactory/linkedServiceAzureBlobStorage:LinkedServiceAzureBlobStorage#1
csharp 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
go 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
java 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
python 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
typescript 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
yaml 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
Example started failing: #/resources/azure:datafactory/linkedServiceAzureBlobStorage:LinkedServiceAzureBlobStorage#1
csharp 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
go 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
java 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
python 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
typescript 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.
yaml 2 Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.

Error 1

30 examples failed with the following error:

Argument or block definition required: An argument or block definition is required here.

Failures include converting the "#/types/azure:compute/VirtualMachineOsProfileSecretVaultCertificate:VirtualMachineOsProfileSecretVaultCertificate/certificateUrl" example with the following HCL to yaml, csharp, go, java, python, typescript:

{
"data":"<Base64-encoded-certificate>",
"dataType":"pfx",
"password":"<pfx-file-password>"
}

Error 2

12 examples failed with the following error:

Unsupported block type: Blocks of type "redis_configuration" are not expected here.

Failures include converting the "#/types/azure:redis/CacheRedisConfiguration:CacheRedisConfiguration/aofStorageConnectionString1" example with the following HCL to csharp, go, java, python, typescript, yaml:

redis_configuration {
aof_backup_enabled              = true
aof_storage_connection_string_0 = "DefaultEndpointsProtocol=https;BlobEndpoint=${azurerm_storage_account.nc-cruks-storage-account.primary_blob_endpoint};AccountName=${azurerm_storage_account.mystorageaccount.name};AccountKey=${azurerm_storage_account.mystorageaccount.primary_access_key}"
aof_storage_connection_string_1 = "DefaultEndpointsProtocol=https;BlobEndpoint=${azurerm_storage_account.mystorageaccount.primary_blob_endpoint};AccountName=${azurerm_storage_account.mystorageaccount.name};AccountKey=${azurerm_storage_account.mystorageaccount.secondary_access_key}"
}

Error 3

6 examples failed with the following error:

not yet implemented: call notImplemented; Function not yet implemented: Function jsondecode not yet implemented

Failures include converting the "#/functions/azure:automation/getVariableObject:getVariableObject" example with the following HCL to java:

data "azurerm_automation_variable_object" "example" {
  name                    = "tfex-example-var"
  resource_group_name     = "tfex-example-rg"
  automation_account_name = "tfex-example-account"
}

output "variable" {
  value = jsondecode(data.azurerm_automation_variable_object.example.value)
}

Error 4

6 examples failed with the following error:

Duplicate resource "azurerm_mssql_server_extended_auditing_policy" configuration: A azurerm_mssql_server_extended_auditing_policy resource named "example" was already declared at /e1219.tf:19,1-67. Resource names must be unique per type in each module.

Failures include converting the "#/resources/azure:mssql/serverExtendedAuditingPolicy:ServerExtendedAuditingPolicy#2" example with the following HCL to java, python, typescript, yaml, csharp, go:

provider "azurerm" {
features {}
}

resource "azurerm_resource_group" "example" {
name     = "example-resources"
location = "West Europe"
}

resource "azurerm_mssql_server" "example" {
  name                         = "example-sqlserver"
  resource_group_name          = azurerm_resource_group.example.name
  location                     = azurerm_resource_group.example.location
  version                      = "12.0"
  administrator_login          = "missadministrator"
  administrator_login_password = "AdminPassword123!"
}

resource "azurerm_mssql_server_extended_auditing_policy" "example" {
  server_id                               = azurerm_mssql_server.example.id
  storage_endpoint                        = azurerm_storage_account.example.primary_blob_endpoint
  storage_account_access_key              = azurerm_storage_account.example.primary_access_key
  storage_account_access_key_is_secondary = false
  retention_in_days                       = 6
}

resource "azurerm_log_analytics_workspace" "example" {
  name                = "example-workspace"
  location            = azurerm_resource_group.example.location
  resource_group_name = azurerm_resource_group.example.name
  sku                 = "PerGB2018"
  retention_in_days   = 30
}

resource "azurerm_eventhub_namespace" "example" {
  name                = "example-eventhub-namespace"
  location            = azurerm_resource_group.example.location
  resource_group_name = azurerm_resource_group.example.name
  sku                 = "Standard"
}

resource "azurerm_eventhub" "example" {
  name                = "example-eventhub"
  namespace_name      = azurerm_eventhub_namespace.example.name
  resource_group_name = azurerm_resource_group.example.name
  partition_count     = 2
  message_retention   = 1
}

resource "azurerm_eventhub_namespace_authorization_rule" "example" {
  name                = "example-eventhub-auth-rule"
  namespace_name      = azurerm_eventhub_namespace.example.name
  resource_group_name = azurerm_resource_group.example.name
  listen              = true
  send                = true
  manage              = true
}

resource "azurerm_mssql_server_extended_auditing_policy" "example" {
  server_id              = azurerm_mssql_server.example.id
  log_monitoring_enabled = true
}

resource "azurerm_monitor_diagnostic_setting" "example" {
  name                           = "example-diagnotic-setting"
  target_resource_id             = "${azurerm_mssql_server.example.id}/databases/master"
  eventhub_authorization_rule_id = azurerm_eventhub_namespace_authorization_rule.example.id
  eventhub_name                  = azurerm_eventhub.example.name
  log_analytics_workspace_id     = azurerm_log_analytics_workspace.example.id

  log {
    category = "SQLSecurityAuditEvents"
    enabled  = true

    retention_policy {
      enabled = false
    }
  }

  metric {
    category = "AllMetrics"

    retention_policy {
      enabled = false
    }
  }
}

Error 5

6 examples failed with the following error:

Duplicate resource "azurerm_data_factory_linked_service_azure_blob_storage" configuration: A azurerm_data_factory_linked_service_azure_blob_storage resource named "test" was already declared at /e579.tf:29,1-73. Resource names must be unique per type in each module.

Failures include converting the "#/resources/azure:datafactory/linkedServiceAzureBlobStorage:LinkedServiceAzureBlobStorage#1" example with the following HCL to go, java, python, typescript, yaml, csharp:

resource "azurerm_resource_group" "example" {
  name     = "example-resources"
  location = "West Europe"
}

data "azurerm_client_config" "current" {
}

resource "azurerm_data_factory" "test" {
  name                = "example"
  location            = azurerm_resource_group.example.location
  resource_group_name = azurerm_resource_group.example.name
}

resource "azurerm_key_vault" "test" {
  name                = "example"
  location            = azurerm_resource_group.example.location
  resource_group_name = azurerm_resource_group.example.name
  tenant_id           = data.azurerm_client_config.current.tenant_id
  sku_name            = "standard"
}

resource "azurerm_data_factory_linked_service_key_vault" "test" {
  name            = "linkkv"
  data_factory_id = azurerm_data_factory.test.id
  key_vault_id    = azurerm_key_vault.test.id
}

resource "azurerm_data_factory_linked_service_azure_blob_storage" "test" {
  name            = "example"
  data_factory_id = azurerm_data_factory.test.id

  sas_uri = "https://example.blob.core.windows.net"
  key_vault_sas_token {
    linked_service_name = azurerm_data_factory_linked_service_key_vault.test.name
    secret_name         = "secret"
  }
}

resource "azurerm_data_factory_linked_service_azure_blob_storage" "test" {
  name            = "example"
  data_factory_id = azurerm_data_factory.test.id

  service_endpoint     = "https://example.blob.core.windows.net"
  service_principal_id = "00000000-0000-0000-0000-000000000000"
  tenant_id            = "00000000-0000-0000-0000-000000000000"
  service_principal_linked_key_vault_key {
    linked_service_name = azurerm_data_factory_linked_service_key_vault.test.name
    secret_name         = "secret"
  }
}

Error 6

6 examples failed with the following error:

Duplicate data "azurerm_resources" configuration: A azurerm_resources data resource named "example" was already declared at /e1203.tf:2,1-35. Resource names must be unique per type in each module.

Failures include converting the "#/functions/azure:core/getResources:getResources" example with the following HCL to typescript, yaml, csharp, go, java, python:

# Get Resources from a Resource Group
data "azurerm_resources" "example" {
  resource_group_name = "example-resources"
}

# Get Resources with specific Tags
data "azurerm_resources" "example" {
  resource_group_name = "example-resources"

  required_tags = {
    environment = "production"
    role        = "webserver"
  }
}

# Get resources by type, create spoke vNet peerings
data "azurerm_resources" "spokes" {
  type = "Microsoft.Network/virtualNetworks"

  required_tags = {
    environment = "production"
    role        = "spokeNetwork"
  }
}

resource "azurerm_virtual_network_peering" "spoke_peers" {
  count = length(data.azurerm_resources.spokes.resources)

  name                      = "hub2${data.azurerm_resources.spokes.resources[count.index].name}"
  resource_group_name       = azurerm_resource_group.hub.name
  virtual_network_name      = azurerm_virtual_network.hub.name
  remote_virtual_network_id = data.azurerm_resources.spokes.resources[count.index].id
}

Error 7

4 examples failed with the following error:

unsupported attribute 'resourceGroupName'; unknown property 'resourceGroupName' among [loadbalancerId name tunnelInterfaces virtualNetworkId]

Failures include converting the "#/resources/azure:lb/natRule:NatRule" example with the following HCL to go, python, typescript, csharp:

resource "azurerm_resource_group" "example" {
  name     = "LoadBalancerRG"
  location = "West Europe"
}

resource "azurerm_public_ip" "example" {
  name                = "PublicIPForLB"
  location            = "West US"
  resource_group_name = azurerm_resource_group.example.name
  allocation_method   = "Static"
}

resource "azurerm_lb" "example" {
  name                = "TestLoadBalancer"
  location            = "West US"
  resource_group_name = azurerm_resource_group.example.name

  frontend_ip_configuration {
    name                 = "PublicIPAddress"
    public_ip_address_id = azurerm_public_ip.example.id
  }
}

resource "azurerm_lb_backend_address_pool" "example" {
  resource_group_name = azurerm_resource_group.example.name
  loadbalancer_id     = azurerm_lb.example.id
  name                = "be"
}

resource "azurerm_lb_nat_rule" "example" {
  resource_group_name            = azurerm_resource_group.example.name
  loadbalancer_id                = azurerm_lb.example.id
  name                           = "RDPAccess"
  protocol                       = "Tcp"
  frontend_port                  = 3389
  backend_port                   = 3389
  frontend_ip_configuration_name = "PublicIPAddress"
}

resource "azurerm_lb_nat_rule" "example1" {
  resource_group_name            = azurerm_resource_group.example.name
  loadbalancer_id                = azurerm_lb.example.id
  name                           = "RDPAccess"
  protocol                       = "Tcp"
  frontend_port_start            = 3000
  frontend_port_end              = 3389
  backend_port                   = 3389
  backend_address_pool_id        = azurerm_lb_backend_address_pool.example.id
  frontend_ip_configuration_name = "PublicIPAddress"
}

Error 8

3 examples failed with the following error:

unsupported attribute 'encryption'; unknown property 'encryption' among [encryptionKey netappAccountId systemAssignedIdentityPrincipalId userAssignedIdentityId]

Failures include converting the "#/resources/azure:netapp/accountEncryption:AccountEncryption" example with the following HCL to csharp, go, typescript:

resource "azurerm_resource_group" "example" {
  name     = "example-resources"
  location = "West Europe"
}

data "azurerm_client_config" "current" {
}

resource "azurerm_user_assigned_identity" "example" {
  name                = "anf-user-assigned-identity"
  location            = azurerm_resource_group.example.location
  resource_group_name = azurerm_resource_group.example.name
}

resource "azurerm_key_vault" "example" {
  name                            = "anfcmkakv"
  location                        = azurerm_resource_group.example.location
  resource_group_name             = azurerm_resource_group.example.name
  enabled_for_disk_encryption     = true
  enabled_for_deployment          = true
  enabled_for_template_deployment = true
  purge_protection_enabled        = true
  tenant_id                       = "00000000-0000-0000-0000-000000000000"

  sku_name = "standard"

  access_policy {
    tenant_id = "00000000-0000-0000-0000-000000000000"
    object_id = data.azurerm_client_config.current.object_id

    key_permissions = [
      "Get",
      "Create",
      "Delete",
      "WrapKey",
      "UnwrapKey",
      "GetRotationPolicy",
      "SetRotationPolicy",
    ]
  }

  access_policy {
    tenant_id = "00000000-0000-0000-0000-000000000000"
    object_id = azurerm_user_assigned_identity.example.principal_id

    key_permissions = [
      "Get",
      "Encrypt",
      "Decrypt"
    ]
  }
}

resource "azurerm_key_vault_key" "example" {
  name         = "anfencryptionkey"
  key_vault_id = azurerm_key_vault.example.id
  key_type     = "RSA"
  key_size     = 2048

  key_opts = [
    "decrypt",
    "encrypt",
    "sign",
    "unwrapKey",
    "verify",
    "wrapKey",
  ]
}

resource "azurerm_netapp_account" "example" {
  name                = "netappaccount"
  location            = azurerm_resource_group.example.location
  resource_group_name = azurerm_resource_group.example.name

  identity {
    type = "UserAssigned"
    identity_ids = [
      azurerm_user_assigned_identity.example.id
    ]
  }
}

resource "azurerm_netapp_account_encryption" "example" {
  netapp_account_id = azurerm_netapp_account.example.id

  user_assigned_identity_id = azurerm_user_assigned_identity.example.id

  encryption {
    key_vault_key_id = azurerm_key_vault_key.example.versionless_id
  }
}

Error 9

3 examples failed with the following error:

unsupported attribute 'certificateBlob'; unknown property 'certificateBlob' among [certificateBlobBase64 certificatePassword containerAppEnvironmentId name tags]

Failures include converting the "#/resources/azure:containerapp/environmentCertificate:EnvironmentCertificate" example with the following HCL to python, typescript, csharp:

resource "azurerm_resource_group" "example" {
  name     = "example-resources"
  location = "West Europe"
}

resource "azurerm_log_analytics_workspace" "example" {
  name                = "acctest-01"
  location            = azurerm_resource_group.example.location
  resource_group_name = azurerm_resource_group.example.name
  sku                 = "PerGB2018"
  retention_in_days   = 30
}

resource "azurerm_container_app_environment" "example" {
  name                       = "myEnvironment"
  location                   = azurerm_resource_group.example.location
  resource_group_name        = azurerm_resource_group.example.name
  log_analytics_workspace_id = azurerm_log_analytics_workspace.example.id
}

resource "azurerm_container_app_environment_certificate" "example" {
  name                         = "myfriendlyname"
  container_app_environment_id = azurerm_container_app_environment.example.id
  certificate_blob             = filebase64("path/to/certificate_file.pfx")
  certificate_password         = "$3cretSqu1rreL"
}

Error 10

2 examples failed with the following error:

unsupported attribute 'externalDocsUrl'; unsupported attribute 'externalDocsDescription'; unknown property 'externalDocsUrl' among [apiTagId description externalDocumentationDescription externalDocumentationUrl]; unknown property 'externalDocsDescription' among [apiTagId description externalDocumentationDescription externalDocumentationUrl]; Provider config not supported: Blocks in provider config are not supported, ignoring azurerm:features

Failures include converting the "#/resources/azure:apimanagement/apiTagDescription:ApiTagDescription" example with the following HCL to python, typescript:

provider "azurerm" {
  features {}
}

resource "azurerm_resource_group" "example" {
  name     = "example-resources"
  location = "West Europe"
}

resource "azurerm_api_management" "example" {
  name                = "example-apim"
  location            = azurerm_resource_group.example.location
  resource_group_name = azurerm_resource_group.example.name
  publisher_name      = "My Company"
  publisher_email     = "[email protected]"

  sku_name = "Developer_1"
}

resource "azurerm_api_management_api" "example" {
  name                = "example-api"
  resource_group_name = azurerm_resource_group.example.name
  api_management_name = azurerm_api_management.example.name
  revision            = "1"
  display_name        = "Example API"
  path                = "example"
  protocols           = ["https"]

  import {
    content_format = "swagger-link-json"
    content_value  = "http://conferenceapi.azurewebsites.net/?format=json"
  }
}

resource "azurerm_api_management_tag" "example" {
  api_management_id = azurerm_api_management.example.id
  name              = "example-Tag"
}

resource "azurerm_api_management_api_tag_description" "example" {
  api_tag_id                = azurerm_api_management_tag.example.id
  description               = "This is an example description"
  external_docs_url         = "https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs"
  external_docs_description = "This is an example external docs description"
}

@t0yv0
Copy link
Member Author

t0yv0 commented Oct 11, 2023

Filed pulumi/pulumi#14263

@t0yv0
Copy link
Member Author

t0yv0 commented Oct 11, 2023

System.IO.IOException: No space left on device...

@t0yv0 t0yv0 mentioned this pull request Oct 11, 2023
@t0yv0
Copy link
Member Author

t0yv0 commented Oct 11, 2023

Also need to spot-check some example changes especially for top resources.

@t0yv0 t0yv0 changed the title Convert examples with pulumi convert DO NOT MERGE Convert examples with pulumi convert Oct 11, 2023
Copy link

Does the PR have any schema changes?

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@t0yv0
Copy link
Member Author

t0yv0 commented Jan 30, 2024

Waiting on one more p/p release.. pulumi/pulumi#15214 updates YAML to 1.5.0 - unreleased as of v3.103.1. Then will try again and expecting to succeed.

t0yv0 added a commit to pulumi/pulumi-terraform-bridge that referenced this pull request Feb 5, 2024
This change is motivated by
pulumi/pulumi-azure#1377 - it seems that the
correct way to identify a provider to the TF converter is by using the
resource prefix. This makes sure "azurerm" is used and not "azure" for
the Azure Classic prover for resource conversion, which in turn makes it
use the in-flight ProviderInfo and stop trying to download an Azure
Classic build from GitHub.
@t0yv0
Copy link
Member Author

t0yv0 commented Feb 5, 2024

Noting Java example quality regresses a bit "exampleResourceXYZ" names - this is already tracked in pulumi/pulumi-converter-terraform#88

@t0yv0
Copy link
Member Author

t0yv0 commented Feb 5, 2024

Finding something suspect with metrics here as only the Java examples seem to be actually changing. Perhaps something is changed in wow we're counting examples. Double-checking.

t0yv0 added a commit to pulumi/ci-mgmt that referenced this pull request Feb 6, 2024
This seems to be an omission that's needed to rollout the converter.
Without it I noticed in pulumi/pulumi-azure#1377
that only Java examples are changing.
@t0yv0 t0yv0 force-pushed the t0yv0/converter branch 2 times, most recently from db44182 to 1fb0cce Compare February 9, 2024 23:37
@t0yv0
Copy link
Member Author

t0yv0 commented Feb 9, 2024

Hm, some more instability

     ///     var exampleResource6 = new Azure.MSSql.ManagedInstanceSecurityAlertPolicy("example", new()
     ///     {
     ///         ResourceGroupName = testazurermResourceGroup.Name,
-    ///         ManagedInstanceName = testazurermMssqlManagedInstance.Name,
+    ///         ManagedInstanceName = test.Name,
     ///         Enabled = true,
-    ///         StorageEndpoint = test.PrimaryBlobEndpoint,
-    ///         StorageAccountAccessKey = test.PrimaryAccessKey,
+    ///         StorageEndpoint = testazurermStorageAccount.PrimaryBlobEndpoint,
+    ///         StorageAccountAccessKey = testazurermStorageAccount.PrimaryAccessKey,
     ///         RetentionDays = 30,
     ///     });
     /// 
diff --git a/sdk/dotnet/Mobile/NetworkSim.cs b/sdk/dotnet/Mobile/NetworkSim.cs
index e82e2e461..3f83ef752 100644
--- a/sdk/dotnet/Mobile/NetworkSim.cs
+++ b/sdk/dotnet/Mobile/NetworkSim.cs
@@ -90,8 +90,8 @@ namespace Pulumi.Azure.Mobile
     ///         {
     ///             new Azure.Mobile.Inputs.NetworkSimStaticIpConfigurationArgs
     ///             {
-    ///                 AttachedDataNetworkId = testdataazurermMobileNetworkAttachedDataNetwork.Id,
-    ///                 SliceId = test.Id,
+    ///                 AttachedDataNetworkId = test.Id,
+    ///                 SliceId = testazurermMobileNetworkSlice.Id,
     ///                 StaticIpv4Address = "2.4.0.1",
     ///             },
     ///         },

@t0yv0 t0yv0 force-pushed the t0yv0/converter branch 2 times, most recently from 9feb724 to f8b9525 Compare February 26, 2024 17:59
@t0yv0 t0yv0 changed the title DO NOT MERGE Convert examples with pulumi convert Convert examples with pulumi convert Feb 26, 2024
@t0yv0 t0yv0 marked this pull request as ready for review February 26, 2024 19:08
@t0yv0 t0yv0 requested review from iwahbe and cnunciato February 26, 2024 19:10
@interurban interurban requested a review from sean1588 February 26, 2024 23:56
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any regressions (except adding back Name), so I think we can merge.

I am seeing some issues on new go examples, but I'm ok addressing that later.

# Test_sql/e2e: Error: error resolving type of resource random: internal error loading package "random": no resource plugin
# 'pulumi-resource-random' found in the workspace or on your $PATH
#
# PULUMI_DISABLE_AUTOMATIC_PLUGIN_ACQUISITION: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to scope this env var to the tfgen build_sdks targets in the Makefile?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes let me look into this in a subsequent PR. This is one round of ci-mgmt edits.

/// {
/// Name = "example-resources",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that we intentionally omit Name because the resource is auto-named. My preference would be that we continue to drop auto-named fields (especially Name, which is likely to be structural), but we shouldn't block on it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear where such a pass would belong. PCL->Go should not care. HCL->PCL in the converter does not have enough metadata about whether a field is autonamed or not, or does it? Perhaps MarshallableDefaultInfo.AutoNamed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pulumi/pulumi-converter-terraform#122 OK presumably this could be put in the converter.

// Name: pulumi.String("examplekeyvault"),
// Location: example.Location,
// ResourceGroupName: example.Name,
// TenantId: *pulumi.String(current.TenantId),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't dereference a pulumi.String.

It looks like we do that a lot in this example.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this blocking further converter rollout, or just something that we should fix as soon as we can?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good question Justin, we implicitly decided to go ahead with the rollout in spite of this issue though it seems fairly prevalent. It should be after all easy to fixup manually if someone is copying the example. Do you think we should revert out and hold?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not revert. We can fix forward.

// "github.com/pulumi/pulumi-azure/sdk/v5/go/azure/core"
// "github.com/pulumi/pulumi-azure/sdk/v5/go/azure/keyvault"
// "github.com/pulumi/pulumi-azure/sdk/v5/go/azure/webpubsub"
// "github.com/pulumi/pulumi-azurerm/sdk/v1/go/azurerm"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we importing a provider that doesn't exist. github.com/pulumi/pulumi-azurerm redirects to github.com/pulumi/pulumi-azure-native, do we mean that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// if err != nil {
// return err
// }
// exampleWebPubsubService, err := index.NewWebPubsubService(ctx, "example", &index.WebPubsubServiceArgs{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index probably isn't the correct name. It isn't imported.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t0yv0 t0yv0 enabled auto-merge (squash) February 27, 2024 15:28
@t0yv0 t0yv0 merged commit c428f3e into master Feb 27, 2024
17 checks passed
@t0yv0 t0yv0 deleted the t0yv0/converter branch February 27, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants