Use the type name to help resolve name clashes #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frassle
commented
Feb 10, 2024
| @@ -31,6 +31,16 @@ | |||
| "type": 4, | |||
| "computed": true | |||
| } | |||
| }, | |||
There was a problem hiding this comment.
I needed another type with a different name to test this case.
| inputOne = "Hello ${aThingResource.result}" | ||
| inputTwo = myaThing | ||
| }) | ||
|
|
||
| resource "aThingAnotherResource" "simple:index:anotherResource" { |
There was a problem hiding this comment.
Note that before this would have just ended up being called "aThingResource2"
Frassle
force-pushed
the
fraser/renameViaType
branch
from
1999591 to
ecff5cc
Compare
Frassle
force-pushed
the
fraser/renameViaType
branch
from
ecff5cc to
c8dd6db
Compare
Zaid-Ajaj
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better conflict resolution for conflicting source names. They'll now use the objects type name to help build a unique name.
See #88