Handle heredoc string delimiters #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonpollack23
force-pushed
the
bpollack/heredoc_strings
branch
2 times, most recently
from
540fc6d to
7196c92
Compare
brandonpollack23
force-pushed
the
bpollack/heredoc_strings
branch
from
7196c92 to
ba9dcf2
Compare
lunaris
reviewed
Nov 5, 2024
brandonpollack23
force-pushed
the
bpollack/heredoc_strings
branch
3 times, most recently
from
0026101 to
2dde7dd
Compare
brandonpollack23
changed the base branch from
main
to
bpollack/template_join_expr
lunaris
reviewed
Nov 11, 2024
brandonpollack23
force-pushed
the
bpollack/template_join_expr
branch
from
7d42c55 to
cebc025
Compare
brandonpollack23
force-pushed
the
bpollack/heredoc_strings
branch
from
2dde7dd to
3166ad4
Compare
Frassle
reviewed
Nov 12, 2024
| @@ -88,7 +88,15 @@ | |||
| } | |||
|
|
|||
| output "heredoc" { | |||
| value = "This is also a template.\nSo we can output the key again ${aKey}\n" | |||
| value = <<END | |||
| This is also a template.\nSo we can output the key again ${aKey}\n | |||
There was a problem hiding this comment.
Won't this keep \n in the final result now because it's now wrapped in a HEREDOC?
There was a problem hiding this comment.
great catch, didn't even notice. Fixed now
brandonpollack23
force-pushed
the
bpollack/heredoc_strings
branch
from
3166ad4 to
56c0711
Compare
brandonpollack23
force-pushed
the
bpollack/heredoc_strings
branch
from
56c0711 to
002c9d8
Compare
Frassle
reviewed
Nov 13, 2024
Previously our template and string literals only handled strings delimited by quotes, this will inspect the source and maintain the same string delim to handle non escaped and multiline strings.
Frassle
reviewed
Nov 14, 2024
| This is also a template. | ||
| So we can output the key again ${aKey} | ||
|
|
||
|
|
Frassle
reviewed
Nov 14, 2024
| value = <<-END | ||
| This is also a template. | ||
| So we can output the key again ${aKey} | ||
|
|
brandonpollack23
force-pushed
the
bpollack/heredoc_strings
branch
from
002c9d8 to
6c97ce1
Compare
Frassle
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintain HEREDOC (<<EOT style) strings when converting.
Previously our template and string literals only handled strings
delimited by quotes, this will inspect the source and maintain the same
string delim to handle non escaped and multiline strings.
Fixes #219