Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump NodeJS in base image to 18 #150

Merged
merged 5 commits into from
Sep 8, 2023
Merged

Bump NodeJS in base image to 18 #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b5b31af
Bump NodeJS in base image to NodeJS LTS (v18)
Jul 11, 2023
fa195d6
Use `node:18-bullseye-slim` for the `pulumi/nodejs` image
justinvp Sep 8, 2023
f647b9e
Upgrade the `pulumi/nodejs` `-ubi` image to use Node 18
justinvp Sep 8, 2023
b74f781
Update CHANGELOG.md
justinvp Sep 8, 2023
9b7b518
Update README.md with policy
justinvp Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# CHANGELOG

## 3.82.0

- Upgrade Node.js in the `pulumi/pulumi` image and `pulumi/nodejs` UBI image to the Active LTS version 18
([#150](https://github.com/pulumi/pulumi-docker-containers/pull/150))

## 3.63.0

- Upgrade Go to 1.20.3. ([#134](https://github.com/pulumi/pulumi-docker-containers/pull/134))
8 changes: 6 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,13 @@ Images are pushed to:
- .NET 6.0
- Go 1.20
- JDK 11
- Node.js 16
- Node.js 18
dixler marked this conversation as resolved.
Show resolved Hide resolved
- Python 3.9

### Version Policy

Language runtimes are kept up-to-date with current LTS versions. You can pin the image tag to a particular version in order to avoid unintended upgrades.

## Scanning

Images are scanned nightly for vulnerabilities. Results are checked periodically for issues that can be remediated (best effort), however there are some issues over which we have no control, e.g. vulnerabilities in base images for which there is no known remediation.
Expand All @@ -58,6 +62,6 @@ The base and SDK images _do not_ include additional tools you might want to use

## Release Cadence

The images in this repository are released automatically as part of the release process for the `pulumi` CLI. You can expect **new minor releases** roughly every other week, with patch releases more frequently as necessary.
The images in this repository are released automatically as part of the release process for the `pulumi` CLI. You can expect **new minor releases** roughly every week, with patch releases more frequently as necessary.

The image tags for each image in this repository mirror the git tags on the `pulumi` CLI. Thus, when [`pulumi v3.35.1`](https://github.com/pulumi/pulumi/releases) is released, you will find a corresponding Docker image [`pulumi/pulumi:3.35.1`](https://hub.docker.com/r/pulumi/pulumi) in DockerHub, ECR, and GHCR.
2 changes: 1 addition & 1 deletion docker/nodejs/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ RUN curl -fsSL https://get.pulumi.com/ | bash -s -- --version $PULUMI_VERSION


# The runtime container
FROM node:lts-bullseye-slim
FROM node:18-bullseye-slim
LABEL org.opencontainers.image.description="Pulumi CLI container for nodejs"
WORKDIR /pulumi/projects

Expand Down
2 changes: 1 addition & 1 deletion docker/nodejs/dnf/nodejs.module
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[nodejs]
name=nodejs
stream=14
stream=18
profiles=
state=enabled
2 changes: 1 addition & 1 deletion docker/pulumi/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ RUN apt-get update -y && \
rm -rf aws && \
rm awscliv2.zip && \
# Add additional apt repos all at once
echo "deb https://deb.nodesource.com/node_16.x $(lsb_release -cs) main" | tee /etc/apt/sources.list.d/node.list && \
echo "deb https://deb.nodesource.com/node_18.x $(lsb_release -cs) main" | tee /etc/apt/sources.list.d/node.list && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do we make sure we don't get caught behind again? looks like Node 20 is becoming LTS starting October 24th

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #158 to track.

echo "deb https://dl.yarnpkg.com/debian/ stable main" | tee /etc/apt/sources.list.d/yarn.list && \
echo "deb [arch=amd64] https://download.docker.com/linux/debian $(lsb_release -cs) stable" | tee /etc/apt/sources.list.d/docker.list && \
echo "deb http://packages.cloud.google.com/apt cloud-sdk-$(lsb_release -cs) main" | tee /etc/apt/sources.list.d/google-cloud-sdk.list && \
Expand Down
Loading