Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set dotnet install dir to /usr/share/dotnet #161

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

martinmesserli
Copy link
Contributor

Instead of /root/.dotnet
Addresses the issue #113: .NET installed under /root/.dotnet is inaccessible when run as non-root

Instead of /root/.dotnet
Addresses the issue pulumi#113: .NET installed under /root/.dotnet is inaccessible when run as non-root
@martinmesserli
Copy link
Contributor Author

Please review this PR and feel free to modify/comment on my proposed change.

@martinmesserli
Copy link
Contributor Author

@justinvp Could you please spare a minute or so to review my PR regarding a change to use the pulumi kubernetes operator with also with .net? Thx in advance.

@justinvp
Copy link
Member

The new location seems oddly specific to pulumi-kubernetes-operator. Is there a more general place it can be installed, not specific to the operator, that would still allow it to be used from the operator?

@martinmesserli
Copy link
Contributor Author

@justinvp I found a shared or more general location for the dotnet installation. There is an argument for the installation script which can be set to the directory /usr/share/dotnet. When specified all binaries will be installed in this directory, which then can also be accessed by non-root users after adding it to the PATH and DOTNET_ROOT variable.

@martinmesserli
Copy link
Contributor Author

@justinvp Could you please share your thoughts on my recent change? I would like to proceed and find a solution so I can use the Pulumi Kubernetes Operator which uses this base image with DOTNET (C# stack).

@justinvp justinvp changed the title set dotnet install dir to /home/pulumi-kubernetes-operator/.dotnet set dotnet install dir to /usr/share/dotnet Oct 30, 2023
@justinvp justinvp added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Oct 30, 2023
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I tested the change in #170

This will be released with the next pulumi/pulumi release, likely within the next couple of days.

@justinvp justinvp merged commit dcfe69d into pulumi:main Oct 30, 2023
1 check passed
@martinmesserli
Copy link
Contributor Author

Thanks @justinvp for reviewing and approving the change. Looking forward to test the new release with the Pulumi Kubernetes Operator.

@martinmesserli martinmesserli deleted the dotnet-6-install-dir-k8s-op branch November 2, 2023 14:28
@martinmesserli
Copy link
Contributor Author

@justinvp Follow up question: Since this change has just been released in pulumi/pulumi:3.92.0, when can I expect the next release of the Pulumi Kubernetes Operator (https://github.com/pulumi/pulumi-kubernetes-operator/releases) which uses this release 3.92.0 or later of the image pulumi/pulumi as a base image?

@rquitales
Copy link

@martinmesserli I've just released v1.14.0 of the Pulumi Kubernetes Operator which will pick up pu/pu v3.92.0 in both our controller code and base image. I'll kick off the helm chart update for this soon, but in the meantime, you should already be able to use the new release.

@martinmesserli
Copy link
Contributor Author

@rquitales That is great news. Will check the new release, THX!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants