Include pyenv and Python 3.9 to 3.12 in the kitchen sink image #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienp
changed the title
julienp
added a commit
to pulumi/pulumi
that referenced
this pull request
Aug 1, 2024
We use pyenv to support python version selection inside docker containers. To enable pyenv support, we need: * pyenv installed * .python-version file in the current directory or any of its parents * PULUMI_LANGUAGE_VERSION_FILES environment variable set to true See pulumi/pulumi-docker-containers#232
julienp
commented
Aug 1, 2024
This was referenced Aug 2, 2024
Closed
julienp
added a commit
to pulumi/pulumi
that referenced
this pull request
Aug 9, 2024
We use pyenv to support python version selection inside docker containers. To enable pyenv support, we need: * pyenv installed * .python-version file in the current directory or any of its parents * PULUMI_LANGUAGE_VERSION_FILES environment variable set to true See pulumi/pulumi-docker-containers#232
github-merge-queue bot
pushed a commit
to pulumi/pulumi
that referenced
this pull request
Aug 19, 2024
Adds the flag `--use-language-version-tools` to `pulumi install`. When passed, and `pyenv` is installed, and a `.python-version` file is in the project directory or any of its parent directories, Pulumi will install the requested python version if it is not already installed. `LanguageRuntime.InstallDependencies` now takes a struct `InstallDependenciesRequest` as argument to make it easier to extend this call with options. See pulumi/pulumi-docker-containers#232 --------- Co-authored-by: Thomas Gummerer <[email protected]>
julienp
commented
Aug 20, 2024
julienp
commented
Aug 20, 2024
Use pyenv to install Python 3.9 to 3.12 in the image. The default version remains 3.9. Once the `pulumi install` command understands .python-version files, this will allow users to pick the Python version.
julienp
force-pushed
the
julienp/pyenv
branch
2 times, most recently
from
38dc8c9
to
c4fa4e9
Compare
julienp
commented
Aug 23, 2024
tgummerer
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use pyenv to install Python 3.9 to 3.12 in the image. The default version remains 3.9.
This is enough to make
.python-versionfiles work when they match the preinstalled versions, however it will fail to run python if the user specifies a patch version that is not installed, for example3.9.0(note that leaving out the patch version works, for example3.9). We need to include support for installing these versions on demand inpulumi install.Ref #222
Fixes #232
Fixes #222