Update nodejs installation script in kitchen sink #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienp
commented
Aug 8, 2024
| rm -rf /var/lib/apt/lists/* | ||
|
|
||
| # Install nodejs and associated tools | ||
| RUN \ |
There was a problem hiding this comment.
This bit is new. I split the above RUN step into multiple steps to keep the steps for various tools grouped together, instead of bundled too much in a single step.
tgummerer
approved these changes
Aug 8, 2024
| nodejs \ | ||
| npm \ |
There was a problem hiding this comment.
Is npm now installed as part of nodejs?
| curl -fsSL https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add - && \ | ||
| echo "deb https://dl.yarnpkg.com/debian/ stable main" | tee /etc/apt/sources.list.d/yarn.list && \ | ||
| # Add nodejs repo | ||
| curl -fsSL https://deb.nodesource.com/setup_18.x | bash - && \ |
There was a problem hiding this comment.
So this vs. https://deb.nodesource.com/node_18.x has changed, and I guess this bundles everything when installing nodejs? That answers my other question about npm as well I guess?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the update to Debian 12,
corepackwas not installed anymore in the kitchen sink image. This is due to the installation method for the nodesource Debian repo having changed.Update the installation method used for nodejs, and add tests to ensure
corepackis present.Fixes #246