Use fnm to switch between node version #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienp
added a commit
to pulumi/pulumi
that referenced
this pull request
Aug 23, 2024
When using the `--use-language-version-tools` flag with `pulumi install`, and `fnm` is installed, we look for `.nvmrc` and `.node-version` files and install the request versio, and `fnm` is installed, we look for `.nvmrc` and `.node-version` files and install the request version. pulumi-docker-containers makes use of this in pulumi/pulumi-docker-containers#253
julienp
added a commit
to pulumi/pulumi
that referenced
this pull request
Aug 23, 2024
When using the `--use-language-version-tools` flag with `pulumi install`, and `fnm` is installed, we look for `.nvmrc` and `.node-version` files and install the request versio, and `fnm` is installed, we look for `.nvmrc` and `.node-version` files and install the request version. This is meant to use within containers where we don’t run within a shell. When running locally, fnm, nvm and similar tools manage the nodejs version via their shell integration. pulumi-docker-containers makes use of this in pulumi/pulumi-docker-containers#253
julienp
added a commit
to pulumi/pulumi
that referenced
this pull request
Aug 23, 2024
When using the `--use-language-version-tools` flag with `pulumi install`, and `fnm` is installed, we look for `.nvmrc` and `.node-version` files and install the request versio, and `fnm` is installed, we look for `.nvmrc` and `.node-version` files and install the request version. This is meant to use within containers where we don’t run within a shell. When running locally, fnm, nvm and similar tools manage the nodejs version via their shell integration. pulumi-docker-containers makes use of this in pulumi/pulumi-docker-containers#253
github-merge-queue bot
pushed a commit
to pulumi/pulumi
that referenced
this pull request
Aug 28, 2024
When using the `--use-language-version-tools` flag with `pulumi install`, and `fnm` is installed, we look for `.nvmrc` and `.node-version` files and install the requested version. This is meant to be used within containers where we don’t run within a shell. When running locally, fnm, nvm and similar tools manage the nodejs version via their shell integration and ensure the correct version is set. pulumi-docker-containers makes use of this in pulumi/pulumi-docker-containers#253
julienp
commented
Aug 29, 2024
docker/pulumi/Dockerfile
Outdated
| RUN curl -fsSL https://get.pulumi.com/ | bash -s -- --version $PULUMI_VERSION && \ | ||
| # TODO: Should use $PULUMI_VERSION, not dev | ||
| # RUN curl -fsSL https://get.pulumi.com/ | bash -s -- --version $PULUMI_VERSION && \ | ||
| RUN curl -fsSL https://get.pulumi.com | sh -s -- --version dev && \ |
There was a problem hiding this comment.
TODO: before merging this PR switch back to the proper version release after the next CLI release
julienp
force-pushed
the
julienp/fnm2
branch
3 times, most recently
from
87bda25
to
0565c00
Compare
tgummerer
approved these changes
Sep 6, 2024
julienp
force-pushed
the
julienp/fnm2
branch
from
29aa3bb
to
74bd939
Compare
Pre-install the current nodejs LTS versions (18, 20, 22) and allow switching between them using `fnm`. The default remains at 18. Fixes #223
julienp
force-pushed
the
julienp/fnm2
branch
from
5fb17a1
to
a059cdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-install the current nodejs LTS versions (18, 20, 22) and allow switching between them using
fnm. The default remains at 18.pulumi/pulumi PR pulumi/pulumi#17060
Fixes #223