Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a nonroot variant for the kitchen sink image #277

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Add a nonroot variant for the kitchen sink image #277

merged 5 commits into from
Sep 25, 2024

Conversation

julienp
Copy link
Contributor

@julienp julienp commented Sep 23, 2024 •
edited
Loading

Fixes #237

EronWright
EronWright reviewed Sep 23, 2024
View reviewed changes
Copy link

@EronWright EronWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@EronWright
Copy link

Are you planning to add the nonroot variant to the language-specific images here? in a follow-up?

@julienp julienp marked this pull request as ready for review September 24, 2024 07:34
@julienp julienp requested a review from a team as a code owner September 24, 2024 07:34
@julienp julienp merged commit 741bad3 into main Sep 25, 2024
39 checks passed
@julienp julienp deleted the julienp/nonroot branch September 25, 2024 08:33
@EronWright EronWright mentioned this pull request Sep 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EronWright EronWright EronWright left review comments

@lunaris lunaris lunaris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add nonroot variants for images
3 participants
@julienp @EronWright @lunaris