Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on dotnet 8 #205

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Run tests on dotnet 8 #205

merged 1 commit into from
Nov 15, 2023

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Nov 15, 2023

Keep running test on 6 as we still support that. Honestly these tests should have been running on 6 and 7 already.

@Frassle Frassle requested a review from a team November 15, 2023 12:53
Copy link
Contributor

@tgummerer tgummerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include 7.0.x in the matrix as well just in case? Or do we expect that to work either way if 6.0.x and 8.0.x work?

@Frassle
Copy link
Member Author

Frassle commented Nov 15, 2023

Should we include 7.0.x in the matrix as well just in case? Or do we expect that to work either way if 6.0.x and 8.0.x work?

Yes, it can get very expensive to test every possible version so we generally just go with oldest and newest.

@Frassle Frassle added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit 35517ac Nov 15, 2023
@Frassle Frassle deleted the fraser/dotnet8 branch November 15, 2023 13:27
jkerken pushed a commit to algompluecker/pulumi-dotnet that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants