Add environment add and remove commands to automation api #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komalali
approved these changes
Dec 14, 2023
Frassle
reviewed
Dec 14, 2023
justinvp
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Some suggestions, but LGTM. I'd be fine with merging this, and we can sort out the CI issue separately.
@Frassle, do we need to keep sdk/Pulumi.Automation/PublicAPI.Shipped.txt up-to-date? If so, is there an easy way to update it. I always find it to be painful because I've done it by hand in the past.
Co-authored-by: Justin Van Patten <[email protected]>
jkerken
pushed a commit
to algompluecker/pulumi-dotnet
that referenced
this pull request
Jul 24, 2024
* Add environment add and remove commands to automation api * Add changelog * fix lint errors * Update sdk/Pulumi.Automation.Tests/MoolumiFactAttribute.cs Co-authored-by: Justin Van Patten <[email protected]> --------- Co-authored-by: Justin Van Patten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for environment add/rm commands to dotnet.