Fix dotnet version #445
Merged
Fix dotnet version #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienp
added
the
impact/no-changelog-required
julienp
force-pushed
the
julienp/fix-dotnet-version
branch
6 times, most recently
from
5750489 to
e483bef
Compare
The `actions/setup-dotnet` action does install the version we want, but the dotnet command still use the runner’s default version. We have to create a `global.json` to make it use the desired version. https://github.com/actions/setup-dotnet?tab=readme-ov-file#matrix-testing
julienp
force-pushed
the
julienp/fix-dotnet-version
branch
from
e483bef to
2ad8f4c
Compare
julienp
commented
Jan 16, 2025
| @@ -46,40 +46,40 @@ public override Task<ParameterizeResponse> Parameterize(ParameterizeRequest requ | |||
|
|
|||
| public override Task<GetSchemaResponse> GetSchema(GetSchemaRequest request, CancellationToken ct) | |||
| { | |||
| var schema = """ | |||
There was a problem hiding this comment.
Raw strings """...""" were introduced in C# 11, however .NET 6.0 only supports up to C# 10. Convert this to use verbatim strings @"...", which unfortunately require double quoting quotes.
lunaris
approved these changes
Jan 17, 2025
julienp
added a commit
that referenced
this pull request
Jan 21, 2025
Follow up to #445, which fixed CI on the latest ubuntu runners, but missed the release job.
julienp
added a commit
that referenced
this pull request
Jan 21, 2025
Follow up to #445, which fixed CI on the latest ubuntu runners, but missed the release job.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
Follow up to #445, which fixed CI on the latest ubuntu runners, but missed the release job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the update to Ubuntu 24.04 for the runners, the preinstalled .NET versions have changed. This revealed some issues with how we select the .NET version to use in the matrix tests. The
actions/setup-dotnetaction does install the version we want, but the dotnet command still use the runner’s default version.We have to create a
global.jsonto make it use the desired version.https://github.com/actions/setup-dotnet?tab=readme-ov-file#matrix-testing