Don't JSON-encode provider config #1308
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
4 tasks
t0yv0
reviewed
May 29, 2024
| @@ -18,14 +18,14 @@ public final class ProviderArgs extends com.pulumi.resources.ResourceArgs { | |||
|
|
|||
| public static final ProviderArgs Empty = new ProviderArgs(); | |||
|
|
|||
| @Import(name="cacheEnabled", json=true) | |||
There was a problem hiding this comment.
Reminder here to remove json from the ImportAnnotation or at least mark deprecated.
|
Should this code in kubernetes provider be changed (from this PR)? It synthesizes the |
|
@EronWright I think the CustomResource feature introduced in: Is not actually affected, afaik, correct me if I am wrong it only affects custom resources that are not providers? The JSON encoding is only affecting explicit providers (and, as we found out, default providers), but I'm hoping it has no interaction with #3020. Happy to discuss further. |
|
We will need to add a flag here for a flagged rollout and resurrect this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See pulumi/pulumi#15032 for context.