Helm Release detect changes to local chart #2568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EronWright
commented
Sep 14, 2023
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2568 +/- ##
==========================================
- Coverage 21.09% 18.64% -2.45%
==========================================
Files 38 47 +9
Lines 8069 9432 +1363
==========================================
+ Hits 1702 1759 +57
- Misses 6274 7574 +1300
- Partials 93 99 +6 ☔ View full report in Codecov by Sentry. |
iwahbe
approved these changes
Sep 15, 2023
t0yv0
reviewed
Sep 15, 2023
|
LGTM but I've never worked with this repo before :) Deferring to @rquitales |
rquitales
reviewed
Sep 15, 2023
| // apply ignoreChanges | ||
| for _, ignore := range req.GetIgnoreChanges() { | ||
| if ignore == "checksum" { | ||
| news["checksum"] = oldInputs["checksum"] |
There was a problem hiding this comment.
Can we add a testcase here for this functionality as well?
|
Note that this fix applies to the |
EronWright
added a commit
that referenced
this pull request
Nov 8, 2023
…2653) <!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md) for Pulumi's contribution guidelines. Help us merge your changes more quickly by adding more details such as labels, milestones, and reviewers.--> ### Proposed changes This PR passes kubeVersion and apiVersions info from the server to Helm to fix a regression that occurred in #2568. ### Related issues (optional) <!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes #1234'. Or link to full URLs to issues or pull requests in other GitHub repositories. --> Fixes: #2631
EronWright
added a commit
that referenced
this pull request
Nov 27, 2023
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
for Pulumi's contribution guidelines.
Help us merge your changes more quickly by adding more details such
as labels, milestones, and reviewers.-->
### Proposed changes
<!--Give us a brief description of what you've done and what it solves.
-->
This PR stabilizes Helm upgrades **by abandoning the use of checksums**
(which was added in v4.5.0, see
[PR](#2568)), while
allowing for local chart change detection via the chart's version
number. That is, the user would be expected to touch the chart's version
to compel Pulumi to roll out the change.
Implementation-wise, this is accomplished by resolving the `version`
property during `Check`. The checked input reflects the goal version,
and if the goal has changed, then `Diff` detects this in the natural way
and effects an upgrade. `Check` no longer uses `helm template` to render
the chart, it simply resolves the chart version.
The diff logic is improved here to use a three-way merge, to be able to
detect drift in the actual Helm release.
The refresh logic is improved to not mutate inputs (as was done in the
past to help with drift detection).
### Related issues (optional)
Closes #2649
<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes
#1234'.
Or link to full URLs to issues or pull requests in other GitHub
repositories. -->
1 task
|
Note that this change was rolled back in #2672 because some charts were found to produce volatile output, causing spurious diffs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR fixes a usability problem with the
kubernetes:helm.sh/v3:Releaseresource when using a local chart. With this fix, Pulumi automatically detects changes to the rendered output of the chart and performs a Helm upgrade accordingly. It does this by persisting a SHA256 checksum of the chart output into the Pulumi stack state.Users may suppress change detection with the
ignoreChangesoption, i.e.ignoreChanges: ["checksum"].Upgrade considerations: after upgrading the provider, users should expect to see a diff (
checksumproperty) and a corresponding Helm upgrade. Helm upgrades are generally idempotent.Related issues (optional)
Closes #2118