Skip Helm upgrade based on checksum #2612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EronWright
force-pushed
the
eronwright/issue-2578
branch
from
b7173cc to
93382d9
Compare
|
The main change of this PR is obsolete because the checksum feature was removed in #2672. I do think this PR contains some new test code that I will cherry-pick into a new PR, then close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Blocked on #2605
Closes #2251
This PR implements an optimization for Helm Release resource, to skip performing a spurious Helm upgrade when the templated content hasn't changed. It does this by looking at the old/new checksum, which is computed by rendering the chart as a template. Note that the checksum incorporates the chart content and the applied values.
Tests are updated to verify that changing the
chart(e.g. from a remote to a local path) causes no changes.