Component option propagation (.NET SDK) #2720
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Epic: #2254
Fixes: #1214
Fixes: #2345
This PR standardizes the option propagation logic for the component resources in the pulumi-kubernetes .NET SDK. The general approach is:
version
andpluginDownloadURL
if specified.Specification
The component resource is responsible for computing sub-options for invokes and for child resource declarations. This table outlines the expected behavior for each resource option when presented to a component resource.
additionalSecretOutputs
aliases
customTimeouts
deleteBeforeReplace
deletedWith
dependsOn
ignoreChanges
import
parent
protect
provider
providers
replaceOnChanges
retainOnDelete
transformations
version
Should propagate when child resource is from the same provider type.
pluginDownloadURL
Should propagate when child resource is from the same provider type.
Testing
A new test case is provided (test case, test program) that exercises option propagation across the component resources:
Upgrade testing must be done manually, with an emphasis on avoiding replacement due to reparenting.
Upgrade Considerations
In previous versions, the
ConfigFile
andConfigGroup
component resources inadvertently assigned the wrong parent to the child resource(s). This would happen when the component resource itself had a parent; the child would be assigned that same parent. This also had the effect of disregarding the component resource's provider in favor of the parent's provider.For example, here's a before/after look at the component hierarchy:
Before:
After:
This PR addresses this issue and attempts to heal existing stacks using aliases. This is effective at avoiding a replacement except in the case where the child was created with the wrong provider. In this case, Pulumi will suggest a replacement of the child resource(s), such that they use the correct provider.
Related issues (optional)