WIP: Use status subresource for deployment rollout awaiting #2759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
|
Closing this PR as the current await logic has been relatively stable for ~3 years and is more status rich. Changing to use the status subresource appears to be something scheduled for a major provider release instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Change await to use status subresource for deployments. This WIP PR watches for deployment events such that whenever the status is updated, we log the rollout status. Tests are expected to fail as they require a full re-write. The code structure could also be properly refactored, since this is currently still just using the existing structure which doesn't make too much sense with the level of nesting there currently is.
Related issues (optional)