Ensure module versions match the downloaded API's minor #3349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blampe
added
the
impact/no-changelog-required
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3349 +/- ##
==========================================
+ Coverage 41.08% 41.11% +0.03%
==========================================
Files 85 85
Lines 12736 12741 +5
==========================================
+ Hits 5232 5238 +6
+ Misses 7115 7113 -2
- Partials 389 390 +1 ☔ View full report in Codecov by Sentry. |
rquitales
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a safeguard to prevent us from accidentally bumping our
k8s.io/apimodule dependency to a new minor without a corresponding update toKUBE_VERSION.Essentially this will prevent us from auto-merging any minor updates, as those will always need to be handled manually. This is more likely to happen now that we have Renovate automatically updating dependencies for us.