Update GitHub Actions workflows. #3355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulumi-bot
added
the
impact/no-changelog-required
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3355 +/- ##
==========================================
+ Coverage 41.24% 41.26% +0.02%
==========================================
Files 85 85
Lines 12740 12740
==========================================
+ Hits 5254 5257 +3
+ Misses 7096 7094 -2
+ Partials 390 389 -1 ☔ View full report in Codecov by Sentry. |
auto-merge was automatically disabled
December 7, 2024 05:04
Pull request was closed
rquitales
added a commit
to pulumi/ci-mgmt
that referenced
this pull request
Dec 9, 2024
…e providers (#1078) The pulumi-kubernetes provider embeds a minified version of a Pulumi JSON schema in the built binary. This file is not checked into source, only the non minified version is. `golangci-lint` is unable to compile the provider for linting if the file does not exist. This PR ensures that we disable any go:embed directives by doing a simple find/replace. This is necessary as `golangci-lint` is unable to skip processing files/directories. Instead, the `exclude-dirs/files` directives will still parse those files/directories, but just suppress warnings/errors. If it is not compilable, in this case due to missing embed files, the linter will also fail. See https://golangci-lint.run/welcome/faq/#why-do-you-have-typecheck-errors Seehttps://github.com/pulumi/pulumi-kubernetes/pull/3355 for example passing run that modifies the workflow file directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated by the update-native-provider-workflows workflow in the pulumi/ci-mgmt repo, from commit b7f0e100bb0abe6720cb1fd92d053fa66129643b.