Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tfgen to use pulumi convert for examples conversion #1401

Merged
merged 18 commits into from
Oct 3, 2023
Merged

Allow tfgen to use pulumi convert for examples conversion #1401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
035e34c
Refactor: introduce extension points in rendering
t0yv0 Sep 29, 2023
1549799
Build a CLI-based examples renderer
t0yv0 Sep 29, 2023
9232456
Sanitize filenames from diagnostics
t0yv0 Sep 29, 2023
336c842
Fix shadowing bug to actually pass the options
t0yv0 Sep 29, 2023
72ca5af
Pass on GCP
t0yv0 Sep 29, 2023
100de09
Lint
t0yv0 Sep 29, 2023
481c38b
Document PULUMI_CONVERT option
t0yv0 Sep 29, 2023
ce5e7d1
Skip currently failing test
t0yv0 Sep 29, 2023
c4c8d24
Fix mapping name computation; GCP still works
t0yv0 Sep 29, 2023
61d0754
Fix test
t0yv0 Sep 29, 2023
a055d30
DO not use needless env vars
t0yv0 Sep 29, 2023
982aa0a
Enable the test; merge PR when it can pass
t0yv0 Oct 2, 2023
a4a020c
Enhance the error message
t0yv0 Oct 2, 2023
e046f4e
Add GenerateSchema test
t0yv0 Oct 2, 2023
fbe0a3f
Skip on Windows
t0yv0 Oct 2, 2023
b271387
Ensure the new code is actually tested
t0yv0 Oct 2, 2023
18166cf
Fix lint
t0yv0 Oct 2, 2023
a7ddbbe
PR feedback
t0yv0 Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@ This repo on its own isn't particularly interesting, until it is used to create

We use git tags and [GitHub Releases](https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository).
1. Maintainers will push a new semver [tag](https://github.com/pulumi/pulumi-terraform-bridge/tags) when appropriate
1. Maintainers will then generate a Release with Changelog using [GitHub Releases](https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository), using the tag pushed in the
1. Maintainers will then generate a Release with Changelog using [GitHub Releases](https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository), using the tag pushed in the
first step.
1. Finally, maintainers will roll out bridge updates across Pulumi providers via manually running the [bridge update
1. Finally, maintainers will roll out bridge updates across Pulumi providers via manually running the [bridge update
workflow in CI Management](https://github.com/pulumi/ci-mgmt/actions/workflows/update-bridge-ecosystem-providers.yml).

### Adapting a New Terraform Provider
Expand Down Expand Up @@ -106,3 +106,4 @@ tfgen, the command that generates Pulumi schema/code for a bridged provider supp
* `PULUMI_SKIP_MISSING_MAPPING_ERROR`: If truthy, tfgen will not fail if a data source or resource in the TF provider is not mapped to the Pulumi provider. Instead, a warning is printed. Default is `false`.
* `PULUMI_SKIP_EXTRA_MAPPING_ERROR`: If truthy, tfgen will not fail if a mapped data source or resource does not exist in the TF provider. Instead, warning is printed. Default is `false`.
* `PULUMI_MISSING_DOCS_ERROR`: If truthy, tfgen will fail if docs cannot be found for a data source or resource. Default is `false`.
* `PULUMI_CONVERT`: If truthy, tfgen will shell out to `pulumi convert` for converting example code from TF HCL to Pulumi PCL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we expect to use this ourselves?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The idea is to roll this out to Tier 1 providers as soon as we can. In terms of retiring this flag, we'd need to make sure our entire fleet has migrated (including Tier 2-3) and then stakeholders and community have migrated, then we can retire it and make it the default.

Loading