-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SDKv2 Detailed Diff tests for lists with many elements #2736
Merged
VenelinMartinov
merged 2 commits into
master
from
vvm/sdkv2_detailed_diff_lists_many_elements
Dec 13, 2024
Merged
Add SDKv2 Detailed Diff tests for lists with many elements #2736
VenelinMartinov
merged 2 commits into
master
from
vvm/sdkv2_detailed_diff_lists_many_elements
Dec 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is part of the following stack: Change managed by git-spice. |
This was referenced Dec 12, 2024
4f55a90
to
d965153
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2736 +/- ##
=======================================
Coverage 69.64% 69.64%
=======================================
Files 301 301
Lines 38726 38726
=======================================
Hits 26969 26969
Misses 10240 10240
Partials 1517 1517 ☔ View full report in Codecov by Sentry. |
c9b0de6
to
b96946f
Compare
d965153
to
c2746ce
Compare
b96946f
to
1c99e00
Compare
c2746ce
to
7c0b26d
Compare
This was referenced Dec 12, 2024
t0yv0
approved these changes
Dec 12, 2024
1c99e00
to
5d5e3d0
Compare
7c0b26d
to
d7e5748
Compare
5d5e3d0
to
bca1c95
Compare
d7e5748
to
9ce613b
Compare
Base automatically changed from
vvm/refactor_sdkv2_detailed_diff_list_replacements
to
master
December 13, 2024 19:15
This PR has been shipped in release v3.99.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for the SDKv2 bridge detailed diff for lists with many elements. Some previews are suboptimal because of #2239