-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable accurate previews for PF tests #2752
Merged
VenelinMartinov
merged 4 commits into
master
from
vvm/disable_accurate_previews_for_pf_tests
Dec 16, 2024
Merged
Disable accurate previews for PF tests #2752
VenelinMartinov
merged 4 commits into
master
from
vvm/disable_accurate_previews_for_pf_tests
Dec 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is part of the following stack:
Change managed by git-spice. |
This was referenced Dec 16, 2024
a081513
to
b1c0b54
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2752 +/- ##
=======================================
Coverage 69.64% 69.64%
=======================================
Files 301 301
Lines 38726 38726
=======================================
Hits 26969 26969
+ Misses 10240 10239 -1
- Partials 1517 1518 +1 ☔ View full report in Codecov by Sentry. |
t0yv0
approved these changes
Dec 16, 2024
VenelinMartinov
added a commit
that referenced
this pull request
Dec 17, 2024
) Disabled accurate previews for the rest of the PF detailed diff tests. These were missed in #2752
This PR has been shipped in release v3.99.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change disables accurate previews for the PF tests as accurate preview rollout for PF is blocked on #2660
The first commit here are the code changes and the second one is test recordings.