Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PF detailed diff test to separate folder #2813

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Jan 7, 2025

This PR moves the PF detailed diff tests to a separate folder. This should make it easier to reuse some code between them without exposing it to the other tests in the folder. No other changes in this PR.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.67%. Comparing base (27c2419) to head (89867cb).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2813   +/-   ##
=======================================
  Coverage   68.66%   68.67%           
=======================================
  Files         325      325           
  Lines       41579    41579           
=======================================
+ Hits        28551    28553    +2     
+ Misses      11423    11420    -3     
- Partials     1605     1606    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov marked this pull request as ready for review January 7, 2025 13:58
This was referenced Jan 7, 2025
@VenelinMartinov VenelinMartinov requested a review from t0yv0 January 7, 2025 18:42
@VenelinMartinov VenelinMartinov force-pushed the vvm/remove_redundant_bridged_provider_util branch from 814b7b9 to 13d6e52 Compare January 13, 2025 12:04
@VenelinMartinov VenelinMartinov force-pushed the vvm/move_pf_detailed_diff_tests branch from 0e4fc2e to d538ddb Compare January 13, 2025 12:04
@VenelinMartinov VenelinMartinov force-pushed the vvm/remove_redundant_bridged_provider_util branch from 13d6e52 to 64c6d07 Compare January 13, 2025 13:37
@VenelinMartinov VenelinMartinov force-pushed the vvm/move_pf_detailed_diff_tests branch from d538ddb to 3e69b03 Compare January 13, 2025 13:37
Base automatically changed from vvm/remove_redundant_bridged_provider_util to master January 13, 2025 15:30
@VenelinMartinov VenelinMartinov force-pushed the vvm/move_pf_detailed_diff_tests branch from 3e69b03 to 89867cb Compare January 13, 2025 15:30
@VenelinMartinov VenelinMartinov enabled auto-merge (squash) January 13, 2025 16:18
@VenelinMartinov VenelinMartinov merged commit 5c26c22 into master Jan 13, 2025
31 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/move_pf_detailed_diff_tests branch January 13, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants