Ensure logging from dynamic schema generation is structured #2823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For logging to show by default, it needs to be in structured form. This PR correctly preserves the log sink after calls to Parameterize, and uses that log sink as the `Sink` in tfgen generator calls.
iwahbe
force-pushed
the
iwahbe/structured-logging-for-dynamic-schema-conversion
branch
from
1fc4e87 to
03a3081
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2823 +/- ##
==========================================
- Coverage 68.65% 68.63% -0.03%
==========================================
Files 325 325
Lines 41537 41566 +29
==========================================
+ Hits 28518 28528 +10
- Misses 11415 11433 +18
- Partials 1604 1605 +1 ☔ View full report in Codecov by Sentry. |
guineveresaenger
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For logging to show by default, it needs to be in structured form. This PR correctly preserves the log sink after calls to Parameterize, and uses that log sink as the
Sinkin tfgen generator calls.