Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the HighTide Fivetran package #5599

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

csechrist
Copy link

@csechrist csechrist commented Oct 3, 2024

Description

Adding a new package?

If this pull request adds a new package:

  • The package's schema URL in this PR is correct.
  • The package metadata file, if present, contains:
    • a supported category (one of Cloud, Infrastructure, Network, Database, Monitoring, or Utility).
    • a valid plugin download URL. See Publish Your Package.
    • a description that explains what the package does.
    • a valid logo URL that points to a PNG whose dimensions conform to the others in this repo (e.g., 100x100).
  • The package repo contains an Overview doc (/docs/_index.md) that includes:
    • a brief explanation of what the package is and what it does.
    • at least one representative example in all supported languages.
    • a front-matter property for the layout set to package.
  • The package repo contains an Installation and Configuration doc (/docs/installation-configuration.md) that includes:
    • links to SDKs in all supported languages.
    • a copyable command for installing the resource plugin if necessary.
    • an example of configuring the provider with pulumi config set.
    • an example of configuring the provider with environment variables.
  • The repository has:
    • a version tag prefixed with v that corresponds with a valid GitHub release and published package SDKs
  • A CODEOWNER has reviewed the PR.
  • A member of the @pulumi/docs team has reviewed all documentation.

@ringods ringods removed the request for review from cnunciato October 31, 2024 17:17
@iwahbe iwahbe added the needs-triage Needs attention from the triage team label Nov 12, 2024
@ringods ringods requested review from mjeffryes and iwahbe November 20, 2024 15:00
@mjeffryes
Copy link
Member

Thanks for the contribution @csechrist! And I apologize that no one replied on this PR right away.

We'd be happy to add this provider in the registry, but we do have a policy that new providers should have SDKs published in all Pulumi languages and that the examples on the docs pages support all Pulumi languages as well. It looks like this package is published everywhere except in Nuget for dotnet users, and docs are only linking to go and js/ts packages.

FWIW, In the next month or two we'll also begin hosting docs for many terraform providers that we support via local packages (see Using Any Terraform Provider). Depending on your motivation for publishing this provider, that might prove to be a lower maintenance option for you.

@mjeffryes mjeffryes added awaiting-feedback Blocked on input from the author and removed needs-triage Needs attention from the triage team labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-feedback Blocked on input from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants