Support custom app directory location #333
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several spots in the README that talk about the what the default puma-dev directory is (e.g., "~/.puma-dev by default", "Puma-dev will startup by default using the directory ~/.puma-dev"), but there wasn't any indication of how to change the directory to anything other than that default value.
I poked around the code a bit. I've never worked with Go, but as best I could tell that directory was hardcoded. I took a stab at adding the ability to set a custom directory with an environment variable.
I tried to lint and build the changes locally, but something is clearly banged up with my local Go setup. If what I came up with isn't correct, I doubt I would be able to fix it in the amount of time I have to spend on this, but it seemed like a simple change so hopefully it's close and maybe someone else can polish it up if necessary.