Implement HLT/KIL Opcodes #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your support, when I get home (I'm away from home these days for personal reasons) I'll take a better look at your patch, |
I prefer to leave the warning message.
|
I think we should add the |
|
@ChessMan14 Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a speedrun category in Super Mario Bros. 3 where you do a glitch involving memory corruption. This memory corruption sometimes causes illegal opcodes to be executed and HLT/KIL opcodes will crash the game on original hardware. The mods therefore decided to ban puNES and Mesen for the category. This PR implements the opcodes so that the cpu will freeze like it should if HLT/KIL opcodes are encountered.