Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/req vars #31

Merged
merged 2 commits into from
Sep 11, 2017
Merged

Feature/req vars #31

merged 2 commits into from
Sep 11, 2017

Conversation

abea
Copy link

@abea abea commented Aug 19, 2017

Resolves #25

  • Adds plugin to check for variable use
  • Sets properties that will require variables, including all colors via regex
  • Sets certain keywords allowed instead of variables
  • Updates README to include plugin installation instructions

@abea
Copy link
Author

abea commented Aug 20, 2017

Should we do this to a new develop branch to work on proper versioning?

@austinstarin
Copy link
Contributor

@abea Looks good. Thanks for taking the lead on this.

That would be great. You need to bump the version in package.json every time you commit to master so that we can publish on npm.

@abea abea self-assigned this Aug 21, 2017
@abea abea changed the base branch from master to development September 11, 2017 17:25
@abea
Copy link
Author

abea commented Sep 11, 2017

Changed to merge into dev branch.

@abea abea merged commit 6788380 into development Sep 11, 2017
@abea abea deleted the feature/req-vars branch September 11, 2017 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgantick bgantick Awaiting requested review from bgantick

@austinstarin austinstarin Awaiting requested review from austinstarin

@arti5m arti5m Awaiting requested review from arti5m

Assignees

@abea abea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abea @austinstarin