Skip to content

Commit

Permalink
fix typo because (RiotGames#109)
Browse files Browse the repository at this point in the history
  • Loading branch information
mrs1669 authored Mar 30, 2024
1 parent 0a73a6c commit 237e7eb
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions docs/decisions/0000-use-better-http-status-codes-in-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

## Context and Problem Statement

The KeyConjurer APIs return 200 whether an error occured or not. It may return 5xx if a fatal error occured during Lambda execution.
The KeyConjurer APIs return 200 whether an error occurred or not. It may return 5xx if a fatal error occurred during Lambda execution.
Instead, the API should return proper HTTP status codes:
* 2xx in case of success
* 4xx in case of user's mistake
Expand All @@ -29,11 +29,11 @@ and it is easier to cover with unit tests.

* Good, because it keeps Terraform configs simpler.
* Good, because it is easier to cover with unit tests.
* Bad, becuase it makes the Lambda handlers a bit more complex.
* Bad, because it makes the Lambda handlers a bit more complex.

### Option 2

* Good, because it keeps the Lambda handler's code simpler.
* Bad, because it makes Terraform configs more complex.
* Bad, because it introduces Velocity Template Language to the project.
* Bad, becuse it is difficult to test automatically in CI/CD.
* Bad, because it is difficult to test automatically in CI/CD.

0 comments on commit 237e7eb

Please sign in to comment.