catch PortAudioError #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the application crashing when no sound device is installed (e.g. on a server).
|
|
||
| logger.warning("Audio device could not be started") | ||
| logger.debug(traceback.format_exc()) |
There was a problem hiding this comment.
This is a very reasonable addition, and if it fixes your problem, I'm happy to merge :)
Can I just ask for one extra line feed to separate the next function?
There was a problem hiding this comment.
Thanks for the feedback, here you go!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I had a problem running Neon Player on a Windows server machine where no sound card was installed, see https://discord.com/channels/285728493612957698/1047111711230009405/1246075184994320384. This PR fixes the application crashing when no sound device is installed. It works for me now when I am running from source.