-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud Heatmap docs #679
Cloud Heatmap docs #679
Conversation
0964e38
to
d2b7a69
Compare
d2b7a69
to
cd2e2d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the light theme this looks fine, but on the dark theme these images look a bit odd. Could we create them using a transparent background? Otherwise, some more white padding would help to frame them better on a dark background.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Maybe I go for more white padding, as the black text will be lost in dark mode otherwise, but I guess I could also hook into the theme system to swap between two images. I will see if vite offers something like that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's possible in Vitepress, but so far we have been trying to avoid creating additional versions of image assets as that is increasing the maintenance effort. Adding patting would be easier!
Co-authored-by: Marc Tonsen <[email protected]>
Co-authored-by: Marc Tonsen <[email protected]>
No description provided.