Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud Heatmap docs #679

Merged
merged 5 commits into from
Apr 23, 2024
Merged

Cloud Heatmap docs #679

merged 5 commits into from
Apr 23, 2024

Conversation

rennis250
Copy link
Contributor

@rennis250 rennis250 commented Apr 22, 2024

No description provided.

@rennis250 rennis250 force-pushed the heatmap_cloud_docs branch from 0964e38 to d2b7a69 Compare April 22, 2024 07:03
@rennis250 rennis250 force-pushed the heatmap_cloud_docs branch from d2b7a69 to cd2e2d8 Compare April 22, 2024 07:03
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the light theme this looks fine, but on the dark theme these images look a bit odd. Could we create them using a transparent background? Otherwise, some more white padding would help to frame them better on a dark background.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Maybe I go for more white padding, as the black text will be lost in dark mode otherwise, but I guess I could also hook into the theme system to swap between two images. I will see if vite offers something like that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's possible in Vitepress, but so far we have been trying to avoid creating additional versions of image assets as that is increasing the maintenance effort. Adding patting would be easier!

@marc-tonsen marc-tonsen merged commit ceb99d1 into master Apr 23, 2024
15 of 22 checks passed
@dourvaris dourvaris deleted the heatmap_cloud_docs branch December 4, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants