Add correct link to eye camera position #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadje
reviewed
Jul 22, 2024
core/best-practices/index.md
Outdated
| @@ -122,7 +122,7 @@ that have unreasonable durations | |||
| ### Pupil Detection and Blinks | |||
| It is worth noting that poor pupil detection in general can lead to false negatives. In such instances, adjusting the | |||
| thresholds can make it easier to detect blinks, but also increases the chance of false positives. It is worth taking the | |||
| time to ensure an optimal setup with regards to [eye camera positioning](/#_3-check-pupil-detection) and | |||
| time to ensure an optimal setup with regards to [eye camera positioning](/getting-started/index.md#3-check-pupil-detection) and | |||
There was a problem hiding this comment.
@weePLs I think the link is wrong. It should be
/getting-started/#_3-check-pupil-detection
instead of getting-started/index.md#3-check-pupil-detection
Can you fix and confirm it works?
There was a problem hiding this comment.
Oh, nevermind the previous post. Yes, it works!
marc-tonsen
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.