(CAT-1869) - Add dsc_timeout param to all dsc resources #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #290 +/- ##
=======================================
Coverage 19.70% 19.70%
=======================================
Files 47 47
Lines 868 868
=======================================
Hits 171 171
Misses 697 697 ☔ View full report in Codecov by Sentry. |
This commit adds the dsc_timeout param to all dsc resources generated by Puppet.Dsc. This allows the user to set a configurable amount of time, in seconds, in which puppet will wait for the dsc invocation to finish. If the timeout passes, and DSC has not returned, the powershell process defined in puppetlabs-pwshlib's dsc_base_provider, will quit the operation and move on.
jordanbreen28
force-pushed
the
cat-1869-add_dsc_timeout_param
branch
from
53bec23
to
e37068d
Compare
david22swan
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the dsc_timeout param to all dsc resources generated by Puppet.Dsc. This allows the user to set a configurable amount of time, in seconds, in which puppet will wait for the dsc invocation to finish.
If the timeout passes, and DSC has not returned, the powershell process defined in puppetlabs-pwshlib's dsc_base_provider, will quit the operation and move on.
Additional Context
Related Issues (if any)
Mention any related issues or pull requests.
Checklist