Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump required pwshlib to 1.2.0 and greater #298

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

jordanbreen28
Copy link

bumps the minimum required puppetlabs/pwshlib to 1.2.0, as dsc_timeout logic is only present in these module versions.

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

bumps the minimum required puppetlabs/pwshlib to 1.2.0, as dsc_timeout
logic is only present in these module versions.
@jordanbreen28 jordanbreen28 marked this pull request as ready for review August 15, 2024 11:25
@jordanbreen28 jordanbreen28 requested a review from a team as a code owner August 15, 2024 11:25
Copy link

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit eb2bf1e into main Aug 15, 2024
10 checks passed
@LukasAud LukasAud deleted the maint-bump_pwshlib branch August 15, 2024 11:25
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 19.70%. Comparing base (3adb824) to head (8a29e94).
Report is 6 commits behind head on main.

Files Patch % Lines
...internal/functions/Update-PuppetModuleMetadata.ps1 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #298   +/-   ##
=======================================
  Coverage   19.70%   19.70%           
=======================================
  Files          47       47           
  Lines         868      868           
=======================================
  Hits          171      171           
  Misses        697      697           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants