when certs are symlinks bolt complained, looking for puppet x509 stuff #27
Conversation
influxdb is a classBreaking changes to this file WILL impact these 1 modules (exact match):This module is declared in 0 of 579 indexed public
|
prolixalias
force-pushed
the
feature_typos_and_linting
branch
2 times, most recently
from
cd07e65
to
013c5c5
Compare
|
@m0dular can you do a quick review of this? @prolixalias would you beable to rebase over the latest commits Thanks! |
Also remove unnecessary require
unused param (port) follow links to certificate(s) add custom type test - dynamic for factset's FQDN linting
prolixalias
force-pushed
the
feature_typos_and_linting
branch
from
013c5c5
to
619a41f
Compare
Sure thing Marty. Done. |
| puppet_conf: 'https://github.com/puppetlabs/puppetlabs-puppet_conf' | ||
| ruby_task_helper: 'https://[email protected]/puppetlabs/puppetlabs-ruby_task_helper' | ||
| stdlib: 'https://github.com/puppetlabs/puppetlabs-stdlib' | ||
| deploy_pe: 'https://github.com/jarretlavallee/puppet-deploy_pe' | ||
| symlinks: |
There was a problem hiding this comment.
Thanks for the contribution, looks good! I only had a question about this symlinks entry, what does this do? I was able to run the unit tests with pdk test unit with and without this, so I think it should set up everything related to this module. Let me know if I'm missing something, I haven't used symlinks in fixtures before so it's entirely possible.
There was a problem hiding this comment.
Hello! I was working around needing influxdb_setup type available to: is_expected.to contain_influxdb_setup(Facter.value(:networking)['fqdn']) in spec/classes/init_spec.rb
Starting to wonder if my pdk is/was misconfigured. I couldn't get it to pass without symlink to itself.
There was a problem hiding this comment.
usually puppetlabs_spec_helper creates the symlink, thats why we removed the symlink option from a lot of modules 🤔
There was a problem hiding this comment.
Shall I resubmit without the additional symlink, not to be confused with title of PR. :)
There was a problem hiding this comment.
That would be great, if you could also update the title to something like "Follow symlinks and fix spelling errors" then I think we're good to merge.
|
I think you helped expose an issue where the manifest isn't passing the |
I'll take #53 if that's okay... Let's get #27 through, will start on port customization tonight off-hours |
|
Sorry for not getting back on this sooner. I think since #53 has been fixed and the linting and typos got fixed somewhere along the way, the only thing left here should be following symlinks. If you could either rebase this PR, or just close and open a new one we should be able to merge that. |
|
|
various typos in README
unused param (port)
follow links to certificate(s)