(PUP-11939) Don't manage firewall in smoke test #2389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvpartytonight
approved these changes
Sep 13, 2023
The latest release of puppetlabs-puppetdb depends on a version of firewall that doesn't support puppet8.
tvpartytonight
force-pushed
the
repo_smoke_5713
branch
from
1017c8e
to
e65d469
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest release of puppetlabs-puppetdb depends on a version of firewall that doesn't support puppet8.
I intentionally didn't target 7.x, because it's only an issue with puppet8 and the puppetdb/firewall modules.
There are two 2 smoke tests described in https://github.com/puppetlabs/puppet-agent/tree/main/ext/smoke#overview
./packages/run-smoke-test.sh suave-easement.delivery.puppetlabs.net retentive-creed.delivery.puppetlabs.net 8.2.0 8.2.1 8.1.0./repos/run-smoke-test.sh coy-pageantry.delivery.puppetlabs.net tart-breeze.delivery.puppetlabs.net astral-roomful.delivery.puppetlabs.net faulty-repeater.delivery.puppetlabs.net 8.2.0 8.2.1 8.1.0