(PA-6329) Add Windows 2016 FIPS platform definition to puppet-agent main #2555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shubhamshinde360
commented
Sep 9, 2024
•
shubhamshinde360
commented
- Unlike windowsfips-2012r2 VMs, 7z is not available at location "C:\Program Files" in windowsfips-2016 VMs, so install 7z from chocolatey.
- Latest choco version does not work on windowsfips-2016 but version 1.4.0 does. So, just like we're using 1.4.0 in puppet-runtime and pxp-agent-vanagon, we use it here as well.
shubhamshinde360
force-pushed
the
PA-6329
branch
from
2d4cbee
to
a453b38
Compare
shubhamshinde360
changed the title
joshcooper
reviewed
Sep 9, 2024
shubhamshinde360
force-pushed
the
PA-6329
branch
from
a453b38
to
a49abb3
Compare
joshcooper
reviewed
Sep 13, 2024
shubhamshinde360
force-pushed
the
PA-6329
branch
from
a801684
to
1b048a0
Compare
- Unlike windowsfips-2012r2 VMs, 7z is not available at location "C:\Program Files" in windowsfips-2016 VMs, so install 7z from chocolatey. - Latest choco version does not work on windowsfips-2016 but version 1.4.0 does. So, just like we're using 1.4.0 in puppet-runtime and pxp-agent-vanagon, we use it here as well.
shubhamshinde360
force-pushed
the
PA-6329
branch
from
e28e127
to
def5727
Compare
amitkarsale
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.