Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) - Removed soon-to-be deprecated RSpec/FilePath cops #369

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

gavindidrichsen
Copy link
Contributor

@gavindidrichsen gavindidrichsen commented Oct 12, 2023

Summary

This PR is a follow on from a recent puppet-lint PR to exclude the soon-to-be deprecated Rspec/FilePath and to favour the new Rspec/SpecFilePathFormat instead.

Additional Context

Since this cop is going to be deprecated in the next major release of rubocop >=3.0.0 according to the documentation, I've:

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@gavindidrichsen gavindidrichsen marked this pull request as ready for review October 13, 2023 11:00
@gavindidrichsen gavindidrichsen requested a review from a team as a code owner October 13, 2023 11:00
@jordanbreen28 jordanbreen28 merged commit a95ae94 into main Oct 13, 2023
10 checks passed
@jordanbreen28 jordanbreen28 deleted the maint_remove_deprecated_rubocops branch October 13, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants