Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update regex to allow underscores in firewall name #1174

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

update regex to allow underscores in firewall name #1174

wants to merge 4 commits into from

Conversation

dlware
Copy link

@dlware dlware commented Nov 2, 2023 •
edited
Loading

Closing Issue #1173

Summary

Updated regex for firewall name to allow the use of underscores.
lib/puppet/type/firewall.rb:136
used puppet strings to update REFERENCE.md

Additional Context

Underscores are supported by the underlying applications and in wide use.

Related Issues (if any)

Issue #1173

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@dlware
update regex to allow underscores in firewall name
edb460d 
update reference as well with puppet strings.
@dlware dlware requested a review from a team as a code owner November 2, 2023 15:15
@CLAassistant
Copy link

CLAassistant commented Nov 2, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dlware
Copy link
Author

dlware commented Mar 6, 2024

Hello All,

Any update on this? Seems like a very simple change.

Thanks,

dlware

@deemon87
Copy link

Up! Any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dlware @CLAassistant @deemon87 @ia-content