Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query gid to prevent errors with missing users with the same id (fixes #1229) #1251

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cmusik
Copy link
Contributor

@cmusik cmusik commented Dec 20, 2024

Summary

If a firewall rule is assigned to a group and the same user does not exist, then we get an error:

Error: /Stage[main]/Main/Firewall[801 - gid testgroup]/gid: change from '1234' to 'testgroup' failed: can't find user for testgroup

This is a fix for #1229.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@cmusik cmusik requested a review from a team as a code owner December 20, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant