Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix haproxy::globals::sort_options_alphabetic not being respected #586

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

1u1-sdoering
Copy link

@1u1-sdoering 1u1-sdoering commented Sep 28, 2023

Summary

I believe commit e0835f8 and its siblings (if any) to be in error.

Additional Context

When specifying "haproxy::globals::sort_options_alphabetic: false" it will be overwritten/ignored by

Boolean                                 $sort_options_alphabetic  = true,

with

$_sort_options_alphabetic = pick($sort_options_alphabetic, $haproxy::globals::sort_options_alphabetic)

pick() according to documentation:
"Returns: Any the first value in a list of values that is not undefined or an empty string.

If sort_options_alphabetic isn't specifically passed into a listen resource we want to global value to be applied.

Current version of haproxy ignores the global and shuffled all my entries into alphabetical order.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@1u1-sdoering 1u1-sdoering requested a review from a team as a code owner September 28, 2023 13:17
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants