Avoid opening the file in postgresql_conf #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested review from
alexjfisher,
bastelfreak,
deric,
SimonHoenscheid,
smortex and
a team
as code owners
bastelfreak
approved these changes
Jun 3, 2024
SimonHoenscheid
approved these changes
Jun 3, 2024
deric
approved these changes
Jun 3, 2024
Using File.open without closing it can leak file descriptors. It's actually not needed at all because File.foreach, File.readlines and File.write all accept a filename. This simplifies the code in the process.
Rather than starting from 0 and always adding 1, this tells with_index to start at 1.
bastelfreak
force-pushed
the
fix-postgresql_conf
branch
from
67edd23 to
f2b193d
Compare
|
did a bit more testing locally to verify this works |
bastelfreak
approved these changes
Jul 12, 2024
Ramesh7
approved these changes
Jul 12, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Using
File.openwithout closing it can leak file descriptors. It's actually not needed at all becauseFile.foreach,File.readlinesandFile.writeall accept a filename. This simplifies the code in the process.Then it simplifies the code by passing an offset to
with_indexto calculate line numbers. Rather than starting from 0 and always adding 1, this tellswith_indexto start at 1.It also fixes the spelling of PostgreSQL in a debug statement.
Checklist
At this point I haven't verified this yet, but submitting it so I can more easily test it on some system.
puppet apply)