Skip to content

Drop puppet_litmus to resolve patron dependency #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joshcooper
Copy link
Contributor

Commit 6161327 introduced a puppet_litmus dependency which transitively caused bundler to try to install patron 0.13.4. In CI, we don't have libcurl headers installed, so patron failed to install its native extensions.

The problem is caused due to this chain of dependencies:

puppet_litmus (1.6.1)
  bolt (~> 4.0)
    orchestrator_client (~> 0.7)
      faraday-net_http_persistent (>= 1.0, < 3.0)

When resolving dependencies, bundler first picked faraday-net_http_persistent 2.0.2 and worked backwards to faraday. Faraday 1.9.0 allows 2.x versions of faraday-* adapters, while faraday 1.10.4 requires 1.x versions. So bundler backtracked from faraday 1.10.4 to 1.9.0.

$ BUNDLER_DEBUG_RESOLVER_TREE=1 bundle install
...
attempting faraday-net_http_persistent 2.0.2
knew: faraday-net_http_persistent >= 2.0.0 depends on Ruby >= 2.6.0
fact: faraday-net_http_persistent >= 2.0.2, < 2.1.0 depends on faraday-net_http < 3
fact: faraday-net_http_persistent >= 2.0.0, < 2.2.0 depends on net-http-persistent ~> 4.0
selected faraday-net_http_persistent 2.0.2
...
attempting faraday 1.9.0
...
fact: faraday >= 1.9.0, < 1.9.1 depends on faraday-patron < 3
...
selected faraday 1.9.0
...
attempting faraday-patron 2.0.2
...
selected faraday-patron 2.0.2
derived: patron >= 0.4.2
...
selected patron 0.13.4

Since we don't use litmus to test puppet_agent, just remove the gem dependency.

Commit 6161327 introduced a puppet_litmus
dependency which transitively caused bundler to try to install patron 0.13.4. In
CI, we don't have libcurl headers installed, so patron failed to install its
native extensions.

The problem is caused due to this chain of dependencies:

    puppet_litmus (1.6.1)
      bolt (~> 4.0)
        orchestrator_client (~> 0.7)
          faraday-net_http_persistent (>= 1.0, < 3.0)

When resolving dependencies, bundler first picked faraday-net_http_persistent
2.0.2 and worked backwards to faraday. Faraday 1.9.0 allows 2.x versions of
faraday-* adapters, while faraday 1.10.4 requires 1.x versions. So bundler
backtracked from faraday 1.10.4 to 1.9.0.

    $ BUNDLER_DEBUG_RESOLVER_TREE=1 bundle install
    ...
    attempting faraday-net_http_persistent 2.0.2
    knew: faraday-net_http_persistent >= 2.0.0 depends on Ruby >= 2.6.0
    fact: faraday-net_http_persistent >= 2.0.2, < 2.1.0 depends on faraday-net_http < 3
    fact: faraday-net_http_persistent >= 2.0.0, < 2.2.0 depends on net-http-persistent ~> 4.0
    selected faraday-net_http_persistent 2.0.2
    ...
    attempting faraday 1.9.0
    ...
    fact: faraday >= 1.9.0, < 1.9.1 depends on faraday-patron < 3
    ...
    selected faraday 1.9.0
    ...
    attempting faraday-patron 2.0.2
    ...
    selected faraday-patron 2.0.2
    derived: patron >= 0.4.2
    ...
    selected patron 0.13.4

Since we don't use litmus to test puppet_agent, just remove the gem dependency.
@joshcooper joshcooper requested review from bastelfreak and a team as code owners August 18, 2025 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant