Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove default value for keyfile: ${user} is the remote user, not local #108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

koollman
Copy link

/home/${user}/.ssh/id_rsa may not exist if $user does not exist locally.
It could also not be the right choice, depending on ssh configuration and $execuser.
If no key file is specified, let ssh find the right one.

@eputnam
Copy link
Contributor

eputnam commented Nov 2, 2017

@koollman thanks for the PR! Could you please have a look at the puppet-lint warnings in travis? https://travis-ci.org/puppetlabs/puppetlabs-rsync/jobs/278679330

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Thomas Samson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants