-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actually add the CI workflow #153
base: main
Are you sure you want to change the base?
Conversation
binford2k
commented
Jan 10, 2024
- Add CloudCI publish and PR testing workflows
- whoops, forgot to add the CI workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once you make checks no angy
Thanks ! I've submitted a PR to address the errors ( #154 ). Do you mind pulling the change (or merge the PR) ? |
well the errors have all been fixed. I don't have time or domain expertise to fix all the warnings. |
It seems most of the warnings are about missing descriptions. I'll try to take time to address these. I'm wondering if we can tweak the job setting to skip warnings now . (so that we can merge this PR before all warnings are fixed) |
I took a quick look at one file (#156) but I don't have the time to finish it now. It would make sense to me to disable |
I've created PR to add data types and parameter descriptions. #157 |
@binford2k Could you please check [1] and rebase this on that one when you get time ? I'm hoping to get this merged (and also create a new release) [1] #157 |
|