Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for server header #98

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Natrinicle
Copy link

Allow address to be undef so that rsyncd can listen on all interfaces
useful for IPv4/IPv6 dual stack boxes where you want the daemon to
listen on both simultaneously. By setting address to :: the server
was only listening on IPv6 but setting it to 0.0.0.0 it was only
listening on IPv4. Leaving it out of the config makes the daemon
listen on all interfaces at startup.

Allow address to be undef so that rsyncd can listen on all interfaces
useful for IPv4/IPv6 dual stack boxes where you want the daemon to
listen on both simultaneously. By setting address to :: the server
was only listening on IPv6 but setting it to 0.0.0.0 it was only
listening on IPv4. Leaving it out of the config makes the daemon
listen on all interfaces at startup.
@TheMeier
Copy link

TheMeier commented Jul 1, 2017

Uhm istn't there a way to specify multiple listen addresses in rsyncd.conf?
If not i guess the best way to go forward would be to use systemd socket activations.

Anyway there might propably a valid use case in simply ommiting the address config all together

Could update the PR with some tests for the changes made?

Allow address to be undef so that rsyncd can listen on all interfaces
useful for IPv4/IPv6 dual stack boxes where you want the daemon to
listen on both simultaneously. By setting address to :: the server
was only listening on IPv6 but setting it to 0.0.0.0 it was only
listening on IPv4. Leaving it out of the config makes the daemon
listen on all interfaces at startup.
@Natrinicle
Copy link
Author

I couldn't find a way to specify multiple listen addresses in rsyncd.conf but perhaps there is a way.

I have changed the test for defaults to check that the address line isn't added to the config. The override is already there by testing for 10.0.0.42.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants