Create Stdlib::File::* types #1298
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b4ldr
reviewed
Mar 10, 2023
types/file/content.pp
Outdated
| @@ -0,0 +1,2 @@ | |||
| # @summary Validate a file content attribute | |||
| type Stdlib::File::Content = Variant[String, Sensitive[String], Deferred[String]] | |||
There was a problem hiding this comment.
TIL: this can also be Binary
b4ldr
reviewed
Mar 10, 2023
Previously these were prefixed, but this creates an explicit namespace.
ekohl
force-pushed
the
file-type-aliases
branch
from
b387486
to
6ce0a5d
Compare
ekohl
requested review from
alexjfisher,
bastelfreak and
smortex
as code owners
bastelfreak
previously approved these changes
Apr 23, 2023
b4ldr
reviewed
Apr 24, 2023
|
|
||
| require 'spec_helper' | ||
|
|
||
| describe 'Stdlib::Filemode' do |
There was a problem hiding this comment.
Suggested change
| describe 'Stdlib::Filemode' do | |
| describe 'Stdlib::File::Content' do |
This should describe the valid input for content. It doesn't list Undef so module authors can enforce content is set. If it's optional, Optional[Stdlib::File::Content] is easy to use.
ekohl
force-pushed
the
file-type-aliases
branch
from
6ce0a5d
to
4fd49ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creats a Stdlib::File namespace for file attributes. It introduces Stdlib::File::Content, but I'm not sure if this is complete. https://www.puppet.com/docs/puppet/7/type.html#file-attribute-content doesn't describe valid or invalid input. Please discuss what should be accepted.